Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully modified to be compatible with OpenCV 4.0.0 #511

Closed
wants to merge 9 commits into from
Closed

Fully modified to be compatible with OpenCV 4.0.0 #511

wants to merge 9 commits into from

Conversation

jiapei100
Copy link

Now, OpenFace is built upon OpenCV 4.0.0 ....

@TadasBaltrusaitis
Copy link
Owner

Hi,

Thanks. I will hold on this for a bit (I'm waiting for OpenCV 4.0.0 to become a stable release that is cross-platform). Further, it seems like it failed the Continuous Integration tests and is not building on Windows.

@Kaspik
Copy link

Kaspik commented Nov 20, 2018

Hey! OpenCV 4.0 is out and stable. OpenCV2 is out on CocoaPods for iOS - but because of OpenFace is not compatible yet, we can't update. How does it look here?

@TadasBaltrusaitis
Copy link
Owner

Thanks for letting me know that OpenCV 4.0 is out. I was waiting for it to become stable to start the transition of OpenFace to it. I don't know how easy it will be, but I will start the investigation soon.

@Kaspik
Copy link

Kaspik commented Nov 22, 2018

We have OpenFace as lib inside project, so I did the migration manually already (it was like 20 mins).

@TadasBaltrusaitis
Copy link
Owner

While migrating in one OS might be easy, I need to make sure it can build easily and works on Windows/Ubuntu/OSX, so will probably take a bit more than 20 minutes :)

@cindyloo
Copy link

hows the upgrade to OpenCV 4.x going? tx

@TadasBaltrusaitis
Copy link
Owner

It is almost complete, you can have a look at the following branch - https://github.com/TadasBaltrusaitis/OpenFace/tree/feature/opencv4 for a work in progress

TadasBaltrusaitis added a commit that referenced this pull request Jul 13, 2019
Change log:

Moving to C++17. This means that the code can only be build using C++17 compilers (e.g. g++ >8 and Visual Studio 2017, clang > 5), fixing related bugs - (#698, #629, #641)
Removing an explicit dependency on boost (all the filesystem operations are performed using std::filesystem or boost::filesysteme). If boost is available it will used boost:filesystem, otherwise std::filesystem (this requires C++17)
Visual Studio 2017 is now the main version for Visual Studio builds, VS 2015 is no longer supported
Updating OpenCV to 4.1 version (#511)
Fixing a bug with output images when using GUI (#694)
Updating RAWImage - #609, so it can be initialized from System.Drawing.Bitmap directly
Fixing overlap detection for multi face tracking (#693)
@TadasBaltrusaitis
Copy link
Owner

OpenFace 4.1 is now the default version used in OpenFace

ratgen pushed a commit to ratgen/OpenFace that referenced this pull request Jul 7, 2022
Change log:

Moving to C++17. This means that the code can only be build using C++17 compilers (e.g. g++ >8 and Visual Studio 2017, clang > 5), fixing related bugs - (TadasBaltrusaitis#698, TadasBaltrusaitis#629, TadasBaltrusaitis#641)
Removing an explicit dependency on boost (all the filesystem operations are performed using std::filesystem or boost::filesysteme). If boost is available it will used boost:filesystem, otherwise std::filesystem (this requires C++17)
Visual Studio 2017 is now the main version for Visual Studio builds, VS 2015 is no longer supported
Updating OpenCV to 4.1 version (TadasBaltrusaitis#511)
Fixing a bug with output images when using GUI (TadasBaltrusaitis#694)
Updating RAWImage - TadasBaltrusaitis#609, so it can be initialized from System.Drawing.Bitmap directly
Fixing overlap detection for multi face tracking (TadasBaltrusaitis#693)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants