Update the OpenCV constants to the corresponding ones in cpp namespace. #578
Conversation
Bug report template
Change some macros to install OpenFace with OpenCV3.4
|
Tested on my mac high Sierra 10.13.6 and should be deployable for other OS. OpenCV version is 3.4.2 from homebrew. Have not been heavily tested. |
|
Somehow the name in the header was wrongly encoded. I updated it with my web browser, so there're multiple commits. |
|
Hi, I'm a bit confused by the PR. OpenFace already works with OpenCV 3.4, or did you encounter any issues with that? |
|
The title is kind of misleading here. It is not really due to the version of OpenCV. |
taoyudong
changed the title
|
Sounds good, thanks for the explanation. Before completing the pull request could you make it to develop rather that the master branch? I use develop as a stop-gap before including changes into master. |
|
Done |
|
Thanks! |
* Removing code duplication and getting rid of some C++ warnings due to float/double and signed/unsigned mixing. * Fixing the screenshot functionality. * Feature/code cleanup (#573) * Header guard cleanup (making sure naming is compliant with C++ standards and consistent). * Removing un-needed nullptr checks. * Removing SSE warnings for x64 builds (as SSE is enabled by default no need for a flag) * Reverting Mat deletion * Adding Visual Studio 2017 solution * Feature/code cleanup (#580) - name of revision - better scripts for model download (not only in Dropbox also OneDrive) * Update the OpenCV constants to the corresponding ones in cpp namespace. (#578) Updating OpenCV macros. * Slight change in packaging code (use a shared download script). * Removing TBB dependency (#590) Removing a TBB dependence for code parallelization (done through OpenCV's parralel_for_ * Updating OpenBLAS (#594) Updating the 64 bit OpenBLAS version for Windows to 0.3.3 (50% perf improvement on certain machines) * Ability to specify output image formats and removing unused quiet parameter. * Update Windows download script (#608) (#610) - Automatically choose correct path to the model files so that it works for both, source code compilation and binary use - Use absolute paths in the system exists methods * Updating version. * Packaging code update.
* Removing code duplication and getting rid of some C++ warnings due to float/double and signed/unsigned mixing. * Fixing the screenshot functionality. * Feature/code cleanup (TadasBaltrusaitis#573) * Header guard cleanup (making sure naming is compliant with C++ standards and consistent). * Removing un-needed nullptr checks. * Removing SSE warnings for x64 builds (as SSE is enabled by default no need for a flag) * Reverting Mat deletion * Adding Visual Studio 2017 solution * Feature/code cleanup (TadasBaltrusaitis#580) - name of revision - better scripts for model download (not only in Dropbox also OneDrive) * Update the OpenCV constants to the corresponding ones in cpp namespace. (TadasBaltrusaitis#578) Updating OpenCV macros. * Slight change in packaging code (use a shared download script). * Removing TBB dependency (TadasBaltrusaitis#590) Removing a TBB dependence for code parallelization (done through OpenCV's parralel_for_ * Updating OpenBLAS (TadasBaltrusaitis#594) Updating the 64 bit OpenBLAS version for Windows to 0.3.3 (50% perf improvement on certain machines) * Ability to specify output image formats and removing unused quiet parameter. * Update Windows download script (TadasBaltrusaitis#608) (TadasBaltrusaitis#610) - Automatically choose correct path to the model files so that it works for both, source code compilation and binary use - Use absolute paths in the system exists methods * Updating version. * Packaging code update.
Change some macros to enable OpenFace with OpenCV3.4 (Not using #ifdef so the updated version can only work with OpenCV3.4. Can be done in the future)