#76: Settings: Change "default_shell" to "default_shells".

Taitava · Oct 25, 2021 · 489f49a · 489f49a
1 parent 6950fde
commit 489f49a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/main.ts b/src/main.ts
@@ -379,7 +379,7 @@ export default class ShellCommandsPlugin extends Plugin {
 
 	public getDefaultShell(): string {
 		let operating_system = getOperatingSystem()
-		let shell_name = this.settings.default_shell[operating_system]; // Can also be undefined.
+		let shell_name = this.settings.default_shells[operating_system]; // Can also be undefined.
 		if (undefined === shell_name) {
 			shell_name = getUsersDefaultShell();
 		}

diff --git a/src/settings/ShellCommandsPluginSettings.ts b/src/settings/ShellCommandsPluginSettings.ts
@@ -2,7 +2,7 @@
 import {ShellCommandsConfiguration} from "./ShellCommandConfiguration";
 
 export interface ShellCommandsPluginSettings {
-    default_shell: IPlatformSpecificString;
+    default_shells: IPlatformSpecificString;
     working_directory: string;
     preview_variables_in_command_palette: boolean;
     shell_commands: ShellCommandsConfiguration;
@@ -15,7 +15,7 @@ export interface ShellCommandsPluginSettings {
 }
 
 export const DEFAULT_SETTINGS: ShellCommandsPluginSettings = {
-    default_shell: {},
+    default_shells: {},
     working_directory: "",
     preview_variables_in_command_palette: true,
     shell_commands: {},

diff --git a/src/settings/ShellCommandsSettingsTab.ts b/src/settings/ShellCommandsSettingsTab.ts
@@ -40,7 +40,7 @@ export class ShellCommandsSettingsTab extends PluginSettingTab {
         ;
 
         // Platforms' default shells
-        createShellSelectionField(this.plugin, containerEl, this.plugin.settings.default_shell, true);
+        createShellSelectionField(this.plugin, containerEl, this.plugin.settings.default_shells, true);
 
         // A <div> element for all command input fields. New command fields can be created at the bottom of this element.
         let command_fields_container = containerEl.createEl("div");