Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operating system specific versions of shell commands + shell selection #76

Closed
Tracked by #100
Taitava opened this issue Oct 17, 2021 Discussed in #38 · 3 comments
Closed
Tracked by #100

Operating system specific versions of shell commands + shell selection #76

Taitava opened this issue Oct 17, 2021 Discussed in #38 · 3 comments
Labels
enhancement New feature or improving change refactoring Rearranging internal stuff that does not show so much to the user.
Milestone
0.7.0

Comments

@Taitava
Copy link
Owner

Taitava commented Oct 17, 2021 •
edited
Loading

Discussed in #38

Write possible comments to the above mentioned discussion. This task is just for Roadmap planning, branching, and time logging.
@Taitava Taitava added the enhancement New feature or improving change label Oct 17, 2021
@Taitava Taitava added this to the 0.7.0 milestone Oct 17, 2021
Taitava added a commit that referenced this issue Oct 17, 2021
@Taitava
WIP: #76: Beginning for OS specific commands and selectable shell sup…
b5f885e 
…port.

These changes are not tested at all! This is completely incomplete!
Taitava added a commit that referenced this issue Oct 21, 2021
@Taitava
#76: Rename new platform specific stuff.
997c2be
@Taitava Taitava mentioned this issue Oct 22, 2021
Closed
4 tasks
Taitava added a commit that referenced this issue Oct 22, 2021
@Taitava
WIP: #76: Refactor the plugin to use TShellCommand class.
f0369cd
Taitava added a commit that referenced this issue Oct 22, 2021
@Taitava
#76: Migrations: Fix MigrateShellCommandToPlatforms().
2e0d55b
Taitava added a commit that referenced this issue Oct 22, 2021
@Taitava
#76: A default platform is always required.
02aed9e
Taitava added a commit that referenced this issue Oct 23, 2021
@Taitava
Merge branch '#76-os-specific-commands' into #78-split-modal-to-tabs
3b26edd
Taitava added a commit that referenced this issue Oct 23, 2021
@Taitava
#76: Rename OperatingSystemName to PlatformId.
c4175d3
Taitava added a commit that referenced this issue Oct 23, 2021
@Taitava
WIP: #76: Settings: Add a setting for selecting a default shell for e…
68f00b9 
…ach platform.
Taitava added a commit that referenced this issue Oct 25, 2021
@Taitava
#76: Settings: Show current system default shell.
07ece20
Taitava added a commit that referenced this issue Oct 25, 2021
@Taitava
#76: Settings: Change text about not recommending CMD.EXE.
f0a8af8
Taitava added a commit that referenced this issue Oct 25, 2021
@Taitava
#76: Ensure that only supported shells can be used.
19c457b
Taitava added a commit that referenced this issue Oct 25, 2021
@Taitava
#76: Settings: Fix default shell changeability.
0f8e462
Taitava added a commit that referenced this issue Oct 25, 2021
@Taitava
#76: Settings: Extract shell selection field to a separate function.
17d35f1
Taitava added a commit that referenced this issue Oct 25, 2021
@Taitava
#76: Settings: Add shell selection field to extra options modal.
6950fde
Taitava added a commit that referenced this issue Oct 25, 2021
@Taitava
#76: Settings: Change "default_shell" to "default_shells".
489f49a
Taitava added a commit that referenced this issue Oct 25, 2021
@Taitava
#76: Settings: Rename "platforms" to "platform_specific_commands".
555d3aa
Taitava added a commit that referenced this issue Oct 25, 2021
@Taitava
#76: Rename "SettingElements" folder to "setting_elements".
5a1344c
Taitava added a commit that referenced this issue Oct 25, 2021
@Taitava
#76: Settings: Extract createShellCommandsField() and friends to a ne…
0dc54b2 
…w file.
Taitava added a commit that referenced this issue Oct 25, 2021
@Taitava
#76: createShellCommandField(): Extract core stuff to a new file.
b9296f6
Taitava added a commit that referenced this issue Oct 25, 2021
@Taitava
#76: ShellCommandExtraOptionsModal: Add platform specific shell comma…
b2bfdc4 
…nd fields.
@Taitava Taitava mentioned this issue Oct 26, 2021
Closed
3 tasks
@Taitava Taitava added the refactoring Rearranging internal stuff that does not show so much to the user. label Oct 29, 2021
Taitava added a commit that referenced this issue Oct 29, 2021
@Taitava
Merge branch '#76-os-specific-commands' into #78-split-modal-to-tabs
d144aa7 
# Conflicts:
#	src/settings/ShellCommandExtraOptionsModal.ts
Taitava added a commit that referenced this issue Oct 29, 2021
@Taitava
#76: ShellCommandExtraOptionsModal.tabOperatingSystemsAndShells(): Pl…
bb14e5f 
…ace command fields before shell fields.
Taitava added a commit that referenced this issue Oct 30, 2021
@Taitava
CHANGELOG.md: Additions as per #76.
f68ab3e
Taitava added a commit that referenced this issue Oct 30, 2021
@Taitava
Merge branch '#76-os-specific-commands' into 0.7.0
a394a62
Taitava added a commit that referenced this issue Oct 30, 2021
@Taitava
#76: Fix creating a field for a new shell command.
3dbd4ee
Taitava added a commit that referenced this issue Nov 6, 2021
@Taitava
#76: Move 'PlatformShells' constant to Shell.ts.
01696c9
Taitava added a commit that referenced this issue Nov 6, 2021
@Taitava
#76: Linux & Mac: Support Dash shell.
6674b96
Taitava added a commit that referenced this issue Nov 6, 2021
@Taitava
#76: CHANGELOG.md: Mention a possible backwards incompatibility due t…
ab327aa 
…o changed default shell on Linux and Mac.
@Taitava
Copy link
Owner Author

Taitava commented Nov 6, 2021

A possible backwards incompatible change

SC versions prior to 0.7.0 used /bin/sh as a shell on Linux and Mac (/bin/sh came as a default value from Node.js's child_process).

  • Linux & Mac: 0.7.0 changes this so that the default shell is retrieved from the current user's $SHELL environment variable. The reason for this change is that I think it's more logical to use a default shell that is defined in the operating system's user's preferences, rather than a hardcoded default shell defined by Node.js, as not many users even know that it comes from Node.js, and not many users know what Node.js is.
  • On Windows, default shell is retrieved from COMSPEC environment variable, and this has not changed.
  • These are only defaults, and a user can change these shells in settings.

If a shell has changed for you, your shell commands might run a bit differently after this upgrade.

@Taitava
Copy link
Owner Author

Taitava commented Nov 6, 2021

This feature should also be pretty well baked at the moment. Let's see how it performs in the beta test.

@Taitava Taitava mentioned this issue Nov 12, 2021
Closed
Taitava added a commit that referenced this issue Nov 23, 2021
@Taitava
CHANGELOG.md: Add a breaking change related to #76.
df7eb34
@Taitava Taitava mentioned this issue Nov 24, 2021
Closed
14 tasks
@Taitava
Copy link
Owner Author

Taitava commented Nov 25, 2021

Done & released.

@Taitava Taitava closed this as completed Nov 25, 2021
Taitava added a commit that referenced this issue Jul 20, 2022
@Taitava
#243/#76: createShellCommandField(): Fix references to SC_MainSetting…
3da2f36 
…sTab.

The mistake was made in commit 0dc54b2 / #76 when moving the logic to a separate file/function.

The mistake did not cause any problems in practise, because nothing actually used the reference. #243 needs to use it, so that's why I fixed it while doing #243.

I don't understand why TypeScript compiler does not yell about this kind of mistakes. When 'this' refers to a function, it's a completely different thing than a specific class 'SC_MainSettingsTab'.
Taitava added a commit that referenced this issue Jan 22, 2023
@Taitava
CHANGELOG.md: 0.7.0: Fix issue #76 link.
4a61e2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improving change refactoring Rearranging internal stuff that does not show so much to the user.
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
1 participant
@Taitava