Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra options modal: Add hotkeys to switch between shell commands #243

Closed
Taitava opened this issue Jul 20, 2022 Discussed in #130 · 1 comment
Closed

Extra options modal: Add hotkeys to switch between shell commands #243

Taitava opened this issue Jul 20, 2022 Discussed in #130 · 1 comment
Labels
enhancement New feature or improving change
Milestone
0.14.0

Comments

@Taitava
Copy link
Owner

Taitava commented Jul 20, 2022 •
edited
Loading

Discussed in #130

Hotkeys: Ctrl/Cmd + Up/Down
@Taitava Taitava added this to the 0.14.0 milestone Jul 20, 2022
@Taitava Taitava added the enhancement New feature or improving change label Jul 20, 2022
Taitava added a commit that referenced this issue Jul 20, 2022
@Taitava
#243/#76: createShellCommandField(): Fix references to SC_MainSetting…
3da2f36 
…sTab.

The mistake was made in commit 0dc54b2 / #76 when moving the logic to a separate file/function.

The mistake did not cause any problems in practise, because nothing actually used the reference. #243 needs to use it, so that's why I fixed it while doing #243.

I don't understand why TypeScript compiler does not yell about this kind of mistakes. When 'this' refers to a function, it's a completely different thing than a specific class 'SC_MainSettingsTab'.
Taitava added a commit that referenced this issue Jul 20, 2022
@Taitava
#243: Tabs.ts: Move tab_button_clicked() inside createTabs().
24fb4e4 
This move prepares for #243 that needs to access data from createTabs() in tab_button_clicked().
Taitava added a commit that referenced this issue Jul 20, 2022
@Taitava
#243: Extra options modal: Add hotkeys to switch between shell commands.
7bba137
@Taitava
Copy link
Owner Author

Taitava commented Jul 20, 2022

Done, will be released in 0.14.0.

Taitava added a commit that referenced this issue Jul 20, 2022
@Taitava
CHANGELOG.md: An addition as per #243.
6da4a9b
Taitava added a commit that referenced this issue Jul 22, 2022
@Taitava
Merge branch '#243-hotkeys-switch-shell-commands' into 0.14.0
74270ce 
# Conflicts:
#	src/settings/ExtraOptionsModal.ts
#	src/settings/setting_elements/Tabs.ts
Taitava added a commit that referenced this issue Jul 22, 2022
@Taitava
#243 and #242: ExtraOptionsModal: A small ESLint fix.
9972e6b
@Taitava Taitava closed this as completed Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improving change
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
1 participant
@Taitava