Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal: Use eslint to improve code readability #242

Closed
Taitava opened this issue Jul 17, 2022 · 1 comment
Closed

Internal: Use eslint to improve code readability #242

Taitava opened this issue Jul 17, 2022 · 1 comment
Labels
refactoring Rearranging internal stuff that does not show so much to the user.
Milestone
0.14.0

Comments

@Taitava
Copy link
Owner

Taitava commented Jul 17, 2022

obsidianmd/obsidian-sample-plugin@6fdd374
@Taitava Taitava added the refactoring Rearranging internal stuff that does not show so much to the user. label Jul 17, 2022
Taitava added a commit that referenced this issue Jul 17, 2022
@Taitava
CHANGELOG.md: Add a change as per #242.
f479d6e
Taitava added a commit that referenced this issue Jul 17, 2022
@Taitava
#242: Use eslint to improve code readability.
a4246da 
Contains just the configuration for eslint. Code changes will be made in a later commit.

Similar changes were made to obsidian-sample-plugin: obsidianmd/obsidian-sample-plugin@6fdd374
Exception: I needed to add "eslint": "8.20.0" myself to package.json.
Taitava added a commit that referenced this issue Jul 17, 2022
@Taitava
#242: Eslint: Automatic code quality fixes.
71df58f 
I used the following command to make these fixes automatically:
eslint .\src\ --fix

I didn't do any fixes indicated by eslint that need to be applied manually. That can be done in a later commit.
Taitava added a commit that referenced this issue Jul 17, 2022
@Taitava
#242: Eslint: Do not check 'lib' folder.
5573056 
'lib' contains code written by others (copied from the internet), and I want to minimize all changes to that kind of code. When there are fewer changes, it makes it easier to compare the code to the original source, if needed. Also bringing updates from the original source is easier.
Taitava added a commit that referenced this issue Jul 17, 2022
@Taitava
#242: Eslint: Do not yell about 'process' being undefined in rollup.c…
253b003 
…onfig.js.

I found this solution from: https://stackoverflow.com/a/50894051/2754026
Taitava added a commit that referenced this issue Jul 17, 2022
@Taitava
#242: ESLint: Remove unused imports.
65b5d2b
Taitava added a commit that referenced this issue Jul 17, 2022
@Taitava
#242: ESLint: Replace 'any' with better data types.
2babe20 
I didn't replace all 'anys' because in some cases replacing them caused hard to fix TypeScript compiler errors.
Taitava added a commit that referenced this issue Jul 17, 2022
@Taitava
#242: ESLint: Replace 'Object' with Record<string, string>.
c89b033 
I didn't replace most of 'Objects' because in some cases replacing them caused hard to fix TypeScript compiler errors.
Taitava added a commit that referenced this issue Jul 17, 2022
@Taitava
#242: ESLint: Use { and } in switch cases.
583dd57
Taitava added a commit that referenced this issue Jul 17, 2022
@Taitava
#242: ESLint: Variable cleanups.
95d1091
@Taitava
Copy link
Owner Author

Taitava commented Jul 17, 2022

Done.

@Taitava Taitava added this to the 0.14.0 milestone Jul 17, 2022
Taitava added a commit that referenced this issue Jul 22, 2022
@Taitava
#243 and #242: ExtraOptionsModal: A small ESLint fix.
9972e6b
@Taitava Taitava closed this as completed Jul 22, 2022
Taitava added a commit that referenced this issue Mar 4, 2023
@Taitava
#242: uniqueArray(): Fix an ESLint error.
34b7f1a 
The error was:
ESLint: Unexpected any. Specify a different type.(@typescript-eslint/no-explicit-any)
Taitava added a commit that referenced this issue Mar 19, 2023
@Taitava
ESLint: Require trailing commas on multiline lists etc.
8e9954e 
I didn't create an issue for this, but let's say it relates to an already closed and released issue #242.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Rearranging internal stuff that does not show so much to the user.
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
1 participant
@Taitava