forked from Kyorai/cuttlefish-fork
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLATS-1928] Fast forward to picaoao/develop-3.0 #1
Open
sashaafm
wants to merge
62
commits into
Talkdesk:develop
Choose a base branch
from
picaoao:develop-3.0
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thumbs targets succeed.
…tructure - relative paths no longer cut it.
…ut EQC. - Expands the list of Thumbs build steps for better coverage. - Adds actual application dependencies to .app.src for dialyzer goodness. - Adds missing record field type specs, also for dialyzer. - Cleans up remaining edoc errors.
…update git's merge pointer to avoid conflicts later.
eunit exports testcase automatically.
There is no Mustache implementation in Rebar 3 apparently, unlike Rebar 2.
The current working directory in the context of test must have changed in Rebar 3 (?).
The error was reported by Dialyzer.
Fix tests + enable CI
This is useful when Erlang applications are packaged as .ez archives: this way, Cuttlefish can read their configuration schema directly. The caller does not need to extract the file(s) and copy them somewhere else.
Bump Lager to 3.7.x
Support reading files & schemas from .ez archives
(cherry picked from commit c8687d9)
... to point to `Kyorai/cuttlefish` instead of `tsloughter/cuttlefish`. While here, remove the deprecated `maintainers` field.
but retains full history.
Introduced in 19c4462.
…-only Ignore whitespace-only lines
Enable build on Windows
Add appvoyer badge
…ally used Currently the -a flag is not used. Originally introduced in [1], it [seemingly] was meant to allow for app.config location customization. That never materialized as the flag is not used anywhere in the codebase besides the getopt definition. Instead we repurpose -a to mean --advanced_conf_file, which was adopted in a fork currently bundled with RabbitMQ. Having a hardcoded location for advanced.config is primarily inconvenient in integration tests that generate configuration files. Note that --app_config has been removed. The version will be bumped to 2.3.0. Per discussion with @dcorbacho @kjnilsson @lukebakken. 1. basho@106b8b7
Repurpose -a to mean --advanced_conf_file as --app_config is unused
Remove unused goldrush dependancy. Control lager version. Add standard travis yaml (with no xref) Merge with up-to-date release from kyorai cuttlefish
Needs to produce script as expected by riak make rel
We have thumbs no more
Develop 3.0 mergerebar3
Attempt to resolve issues in riak test_deps
Without commenting the line, it would fail to compile when compiling as a dep in mix.exs. erlang/rebar3#1568
danielcorreia96
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA PLATS-1928