Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): error queries will never fetch when using useQuery().promise #8508

Closed
wants to merge 3 commits into from
Closed

fix(react): error queries will never fetch when using useQuery().promise #8508

wants to merge 3 commits into from

Conversation

KATT
Copy link
Contributor

@KATT KATT commented Jan 6, 2025 •
edited
Loading

Fixes #8507

🚧 only tests so far

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 6, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 1aefaed.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 2m 46s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-06 19:40:02 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 6, 2025 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8508

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8508

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8508

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8508

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8508

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8508

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8508

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8508

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8508

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8508

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8508

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8508

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8508

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8508

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8508

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8508

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8508

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8508

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8508

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8508

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8508

commit: 1aefaed

@KATT KATT changed the title fix(core): getOptimisticResult() should return pending for previously errored queries fix(react): error queries will never fetch when using useQuery().promise Jan 6, 2025
@KATT KATT mentioned this pull request Jan 6, 2025
Closed
@KATT KATT closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useQuery().promise will always be a rejected promise if the query is in an error state
1 participant
@KATT