Skip to content

fix(react): error queries will never fetch when using useQuery().promise #8508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions packages/react-query/src/__tests__/useQuery.promise.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,73 @@ describe('useQuery().promise', () => {
expect(callCount).toBe(1)
})

it.only('should work with a previously errored query', async () => {
const key = queryKey()
const renderStream = createRenderStream({ snapshotDOM: true })
const queryFn = vi.fn(async () => {
await sleep(1)
return 'test'
})

// Ensure the query is in an errored state
await queryClient.prefetchQuery({
queryKey: key,
queryFn: () => {
throw new Error('test')
},
retry: false,
})

function MyComponent() {
useTrackRenders()
const query = useQuery({
queryKey: key,
queryFn,
staleTime: Infinity,
})

const data = React.use(query.promise)
return <>{data}</>
}

function Loading() {
useTrackRenders()
return <>loading..</>
}

function Page() {
useTrackRenders()

return (
<div>
<React.Suspense fallback={<Loading />}>
<MyComponent />
</React.Suspense>
</div>
)
}

await renderStream.render(
<QueryClientProvider client={queryClient}>
<Page />
</QueryClientProvider>,
)

{
const result = await renderStream.takeRender()
result.withinDOM().getByText('loading..')
}

expect(queryFn).toHaveBeenCalledTimes(1)

{
const result = await renderStream.takeRender()
result.withinDOM().getByText('test')
}

expect(queryFn).toHaveBeenCalledTimes(1)
})

it('parallel queries', async () => {
const key = queryKey()
const renderStream = createRenderStream({ snapshotDOM: true })
Expand Down
Loading