Skip to content

test(react-query/QueryResetErrorBoundary): use precise time in 'advanceTimersByTimeAsync', and add 'expect' using 'toBeInTheDocument' #9456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2025
Merged

test(react-query/QueryResetErrorBoundary): use precise time in 'advanceTimersByTimeAsync', and add 'expect' using 'toBeInTheDocument' #9456

merged 2 commits into from
Jul 20, 2025

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Jul 18, 2025

No description provided.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 18, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 67628b0

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 32s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 28s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-20 01:28:46 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 18, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9456

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9456

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9456

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9456

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9456

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9456

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9456

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9456

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9456

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9456

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9456

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9456

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9456

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9456

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9456

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9456

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9456

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9456

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9456

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9456

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9456

commit: 67628b0

@sukvvon
test(react-query/QueryResetErrorBoundary): use precise time in 'advan…
e4c2fc8 
…ceTimersByTimeAsync', and add 'expect' using 'toBeInTheDocument'
@sukvvon sukvvon force-pushed the test/react-query-QueryResetErrorBoundary-use-precise-time-advanceTimersByTimeAsync branch from 33bc946 to e4c2fc8 Compare July 18, 2025 15:37
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (63bc828) to head (67628b0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9456       +/-   ##
===========================================
+ Coverage   45.30%   84.38%   +39.07%     
===========================================
  Files         208       26      -182     
  Lines        8283      365     -7918     
  Branches     1863      107     -1756     
===========================================
- Hits         3753      308     -3445     
+ Misses       4085       48     -4037     
+ Partials      445        9      -436
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query 95.95% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

manudeli
manudeli approved these changes Jul 20, 2025
View reviewed changes
packages/react-query/src/__tests__/QueryResetErrorBoundary.test.tsx
await act(() => vi.advanceTimersByTimeAsync(11))
rendered.getByText('error boundary')
rendered.getByText('retry')
await act(() => vi.advanceTimersByTimeAsync(10))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tight 👍

@manudeli manudeli merged commit e349d85 into TanStack:main Jul 20, 2025
7 checks passed
@sukvvon sukvvon deleted the test/react-query-QueryResetErrorBoundary-use-precise-time-advanceTimersByTimeAsync branch July 20, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manudeli manudeli manudeli approved these changes

Assignees
No one assigned
Labels
package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sukvvon @manudeli