Skip to content

test(react-query/QueryResetErrorBoundary): use precise time in 'advanceTimersByTimeAsync', and add 'expect' using 'toBeInTheDocument' #9456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2025
Merged

test(react-query/QueryResetErrorBoundary): use precise time in 'advanceTimersByTimeAsync', and add 'expect' using 'toBeInTheDocument' #9456

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4c2fc8
test(react-query/QueryResetErrorBoundary): use precise time in 'advan…
sukvvon Jul 18, 2025
67628b0
Merge branch 'main' into test/react-query-QueryResetErrorBoundary-use…
manudeli Jul 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions packages/react-query/src/__tests__/QueryResetErrorBoundary.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ describe('QueryErrorResetBoundary', () => {
shouldReset = false
fireEvent.click(rendered.getByText('retry'))
await vi.advanceTimersByTimeAsync(11)
rendered.getByText('error boundary')
expect(rendered.getByText('error boundary')).toBeInTheDocument()
consoleMock.mockRestore()
})

Expand Down Expand Up @@ -523,15 +523,15 @@ describe('QueryErrorResetBoundary', () => {
)

await vi.advanceTimersByTimeAsync(11)
rendered.getByText('error boundary')
rendered.getByText('retry')
expect(rendered.getByText('error boundary')).toBeInTheDocument()
expect(rendered.getByText('retry')).toBeInTheDocument()
fireEvent.click(rendered.getByText('retry'))
await vi.advanceTimersByTimeAsync(11)
rendered.getByText('error boundary')
rendered.getByText('retry')
expect(rendered.getByText('error boundary')).toBeInTheDocument()
expect(rendered.getByText('retry')).toBeInTheDocument()
fireEvent.click(rendered.getByText('retry'))
await vi.advanceTimersByTimeAsync(11)
rendered.getByText('error boundary')
expect(rendered.getByText('error boundary')).toBeInTheDocument()
expect(fetchCount).toBe(3)
consoleMock.mockRestore()
})
Expand Down Expand Up @@ -590,16 +590,16 @@ describe('QueryErrorResetBoundary', () => {
</QueryErrorResetBoundary>,
)

await act(() => vi.advanceTimersByTimeAsync(11))
rendered.getByText('error boundary')
rendered.getByText('retry')
await act(() => vi.advanceTimersByTimeAsync(10))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tight 👍

expect(rendered.getByText('error boundary')).toBeInTheDocument()
expect(rendered.getByText('retry')).toBeInTheDocument()
fireEvent.click(rendered.getByText('retry'))
await act(() => vi.advanceTimersByTimeAsync(11))
rendered.getByText('error boundary')
rendered.getByText('retry')
await act(() => vi.advanceTimersByTimeAsync(10))
expect(rendered.getByText('error boundary')).toBeInTheDocument()
expect(rendered.getByText('retry')).toBeInTheDocument()
fireEvent.click(rendered.getByText('retry'))
await act(() => vi.advanceTimersByTimeAsync(11))
rendered.getByText('data')
await act(() => vi.advanceTimersByTimeAsync(10))
expect(rendered.getByText('data')).toBeInTheDocument()
expect(fetchCount).toBe(3)
expect(renders).toBe(1)
consoleMock.mockRestore()
Expand Down Expand Up @@ -813,12 +813,12 @@ describe('QueryErrorResetBoundary', () => {
</QueryErrorResetBoundary>,
)

await act(() => vi.advanceTimersByTimeAsync(11))
await act(() => vi.advanceTimersByTimeAsync(10))
expect(rendered.getByText('error boundary')).toBeInTheDocument()
expect(rendered.getByText('retry')).toBeInTheDocument()
succeed = true
fireEvent.click(rendered.getByText('retry'))
await act(() => vi.advanceTimersByTimeAsync(11))
await act(() => vi.advanceTimersByTimeAsync(10))
expect(rendered.getByText('data')).toBeInTheDocument()
consoleMock.mockRestore()
})
Expand Down
Loading