Skip to content

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Oct 8, 2025

Reverts #5374 (comment)

Closes #5391

Summary by CodeRabbit

  • Bug Fixes

    • Corrected package entry points for ESM/CJS, improving import resolution across bundlers and Node environments.
  • Chores

    • Updated Solid.js dependency strategy: moved to a peer dependency (>=1.9.5) to ensure compatibility and reduce duplicates. Users should ensure Solid.js v1.9.5 or newer is installed.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 8, 2025

Walkthrough

Adjusts package entry points and exports in packages/router-devtools-core/package.json and reclassifies solid-js across dependencies and peerDependencies.

Changes

Cohort / File(s) Summary of changes
Package metadata
packages/router-devtools-core/package.json
Updated main/module to ./dist/cjs/index.cjs and ./dist/esm/index.js; updated exports defaults accordingly; moved solid-js from devDependencies to dependencies and added to peerDependencies (>=1.9.5).

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • brenelz
  • schiller-manuel

Poem

A nibble of paths, a hop to dist,
Exports aligned—no routes are missed.
Peer the solid, deps in tow,
Devtools thump with steady glow.
With whisker-twitch and gentle cheer,
The bun declares: “All clear!” 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Linked Issues Check ❓ Inconclusive While this PR reverts PR #5374’s export path changes and adds solid-js as a declared dependency and peerDependency, it is not clear from the provided package.json updates alone that the ERR_PACKAGE_PATH_NOT_EXPORTED error for the ‘solid-js/web’ subpath is resolved at runtime. There are no modifications to the solid-js exports or import statements that explicitly address the missing ‘web’ export, so the link to the original issue’s failure mode remains unverified. Please include evidence—such as updated exports for the ‘solid-js/web’ subpath or test results demonstrating a successful runtime import—to confirm that this change fully resolves the reported error.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Out of Scope Changes Check ✅ Passed All modifications in this PR are confined to the router-devtools-core package.json, focusing on reverting entry-point paths and adjusting solid-js dependency declarations, which directly relate to the objectives of restoring the prior export configuration and ensuring solid-js is included. There are no unrelated files or features altered in this changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The title clearly states that this pull request fixes the router-devtools-core package by adding Solid JS to its dependencies, which directly reflects the primary intent of resolving the ERR_PACKAGE_PATH_NOT_EXPORTED issue. It uses a conventional commit style with scope and a concise description of the main change. This ensures anyone reviewing the history understands the core purpose of the update at a glance.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix(router-devtools-core)--add-solid-js-to-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@birkskyum birkskyum changed the title Fix(router-devtools-core): add solid js to deps Fix(router-devtools-core): Reverts #5374 Oct 8, 2025
@nx-cloud
Copy link

nx-cloud bot commented Oct 8, 2025

View your CI Pipeline Execution ↗ for commit 6b6369e

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 6m 47s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 29s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-08 00:24:53 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 8, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5403

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5403

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5403

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5403

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5403

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5403

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5403

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5403

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5403

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5403

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5403

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5403

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5403

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5403

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5403

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5403

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5403

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5403

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5403

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5403

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5403

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5403

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5403

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5403

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5403

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5403

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5403

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5403

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5403

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5403

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5403

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5403

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5403

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5403

commit: 6b6369e

@birkskyum birkskyum merged commit c7a9ced into main Oct 8, 2025
6 checks passed
@birkskyum birkskyum deleted the fix(router-devtools-core)--add-solid-js-to-deps branch October 8, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@tanstack/solid-router-devtools@1.132.44 breaks hosted app with ERR_PACKAGE_PATH_NOT_EXPORTED

2 participants