chore(solid): bump solid-js to ^1.9.9 to align seroval versions #5586
Conversation
WalkthroughUpdated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
birkskyum
force-pushed
the
bump-solid-1.9.9
branch
from
5ca2b00 to
b779d95
Compare
|
View your CI Pipeline Execution ↗ for commit 186e670
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
examples/solid/quickstart-file-based/package.json (1)
13-14: Useworkspace:*protocol for internal @TanStack dependencies per coding guidelines.Internal dependencies should use the workspace protocol to ensure consistent versions across the monorepo. Update lines 13–14 and 22 to reference workspace versions.
"dependencies": { "@tailwindcss/postcss": "^4.1.15", - "@tanstack/solid-router": "^1.133.24", - "@tanstack/solid-router-devtools": "^1.133.24", + "@tanstack/solid-router": "workspace:*", + "@tanstack/solid-router-devtools": "workspace:*", "postcss": "^8.5.1", "redaxios": "^0.5.1", "solid-js": "^1.9.9", "tailwindcss": "^4.1.15", "zod": "^3.24.2" }, "devDependencies": { - "@tanstack/router-plugin": "^1.133.22", + "@tanstack/router-plugin": "workspace:*", "typescript": "^5.7.2", "vite": "^7.1.7", "vite-plugin-solid": "^2.11.10" }As per coding guidelines.
Also applies to: 22-22
🧹 Nitpick comments (1)
examples/solid/start-bare/package.json (1)
12-14: Consider usingworkspace:*protocol for internal dependencies.Per the coding guidelines, internal dependencies should use the
workspace:*protocol instead of pinned versions. This applies to the @tanstack-scoped packages.Apply this diff to align with the coding guidelines:
"dependencies": { - "@tanstack/solid-router": "^1.133.24", - "@tanstack/solid-router-devtools": "^1.133.24", - "@tanstack/solid-start": "^1.133.24", + "@tanstack/solid-router": "workspace:*", + "@tanstack/solid-router-devtools": "workspace:*", + "@tanstack/solid-start": "workspace:*", "solid-js": "^1.9.9",This change should be applied consistently across all internal package.json files in the monorepo if not already done. As per coding guidelines.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (49)
e2e/solid-router/basic-esbuild-file-based/package.json(1 hunks)e2e/solid-router/basic-file-based-code-splitting/package.json(1 hunks)e2e/solid-router/basic-file-based/package.json(1 hunks)e2e/solid-router/basic-scroll-restoration/package.json(1 hunks)e2e/solid-router/basic-solid-query-file-based/package.json(1 hunks)e2e/solid-router/basic-solid-query/package.json(1 hunks)e2e/solid-router/basic-virtual-file-based/package.json(1 hunks)e2e/solid-router/basic-virtual-named-export-config-file-based/package.json(1 hunks)e2e/solid-router/basic/package.json(1 hunks)e2e/solid-router/rspack-basic-file-based/package.json(1 hunks)e2e/solid-router/rspack-basic-virtual-named-export-config-file-based/package.json(1 hunks)e2e/solid-router/scroll-restoration-sandbox-vite/package.json(1 hunks)e2e/solid-start/basic-auth/package.json(1 hunks)e2e/solid-start/basic-solid-query/package.json(1 hunks)e2e/solid-start/basic-tsr-config/package.json(1 hunks)e2e/solid-start/basic/package.json(1 hunks)e2e/solid-start/custom-basepath/package.json(1 hunks)e2e/solid-start/query-integration/package.json(1 hunks)e2e/solid-start/scroll-restoration/package.json(1 hunks)e2e/solid-start/selective-ssr/package.json(1 hunks)e2e/solid-start/server-functions/package.json(1 hunks)e2e/solid-start/server-routes/package.json(1 hunks)e2e/solid-start/spa-mode/package.json(1 hunks)e2e/solid-start/virtual-routes/package.json(1 hunks)e2e/solid-start/website/package.json(1 hunks)examples/solid/basic-devtools-panel/package.json(1 hunks)examples/solid/basic-file-based/package.json(1 hunks)examples/solid/basic-non-nested-devtools/package.json(1 hunks)examples/solid/basic-solid-query-file-based/package.json(1 hunks)examples/solid/basic-solid-query/package.json(1 hunks)examples/solid/basic-ssr-streaming-file-based/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/kitchen-sink-file-based/package.json(1 hunks)examples/solid/kitchen-sink-solid-query-file-based/package.json(1 hunks)examples/solid/kitchen-sink-solid-query/package.json(1 hunks)examples/solid/quickstart-file-based/package.json(1 hunks)examples/solid/start-bare/package.json(1 hunks)examples/solid/start-basic-auth/package.json(1 hunks)examples/solid/start-basic-cloudflare/package.json(1 hunks)examples/solid/start-basic-netlify/package.json(1 hunks)examples/solid/start-basic-nitro/package.json(1 hunks)examples/solid/start-basic-solid-query/package.json(1 hunks)examples/solid/start-basic-static/package.json(1 hunks)examples/solid/start-basic/package.json(1 hunks)packages/router-devtools-core/package.json(1 hunks)packages/solid-router-devtools/package.json(1 hunks)packages/solid-router-ssr-query/package.json(1 hunks)packages/solid-router/package.json(1 hunks)packages/solid-start-server/package.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Use workspace:* protocol for internal dependencies in package.json files
Files:
e2e/solid-start/basic-auth/package.jsonexamples/solid/start-basic-auth/package.jsonexamples/solid/start-basic-cloudflare/package.jsone2e/solid-router/basic-file-based/package.jsone2e/solid-router/basic-solid-query-file-based/package.jsone2e/solid-start/scroll-restoration/package.jsone2e/solid-router/basic-virtual-file-based/package.jsonexamples/solid/start-bare/package.jsonexamples/solid/basic-non-nested-devtools/package.jsone2e/solid-router/basic/package.jsone2e/solid-router/basic-file-based-code-splitting/package.jsonexamples/solid/basic-file-based/package.jsone2e/solid-router/basic-solid-query/package.jsonexamples/solid/basic-devtools-panel/package.jsonexamples/solid/start-basic-nitro/package.jsonpackages/router-devtools-core/package.jsonpackages/solid-start-server/package.jsone2e/solid-start/spa-mode/package.jsone2e/solid-router/rspack-basic-file-based/package.jsone2e/solid-start/website/package.jsonexamples/solid/basic-solid-query-file-based/package.jsonexamples/solid/basic/package.jsone2e/solid-start/basic-tsr-config/package.jsone2e/solid-start/query-integration/package.jsonexamples/solid/kitchen-sink-solid-query/package.jsonexamples/solid/quickstart-file-based/package.jsone2e/solid-start/virtual-routes/package.jsonexamples/solid/kitchen-sink-solid-query-file-based/package.jsonexamples/solid/kitchen-sink-file-based/package.jsone2e/solid-start/server-routes/package.jsone2e/solid-router/basic-esbuild-file-based/package.jsone2e/solid-start/custom-basepath/package.jsonexamples/solid/basic-ssr-streaming-file-based/package.jsone2e/solid-start/server-functions/package.jsonpackages/solid-router-devtools/package.jsonpackages/solid-router-ssr-query/package.jsonexamples/solid/start-basic/package.jsone2e/solid-start/selective-ssr/package.jsonexamples/solid/start-basic-static/package.jsone2e/solid-router/basic-virtual-named-export-config-file-based/package.jsone2e/solid-router/rspack-basic-virtual-named-export-config-file-based/package.jsonexamples/solid/start-basic-solid-query/package.jsonexamples/solid/basic-solid-query/package.jsone2e/solid-start/basic/package.jsone2e/solid-router/scroll-restoration-sandbox-vite/package.jsone2e/solid-start/basic-solid-query/package.jsonexamples/solid/start-basic-netlify/package.jsone2e/solid-router/basic-scroll-restoration/package.jsonpackages/solid-router/package.json
e2e/**
📄 CodeRabbit inference engine (AGENTS.md)
Store end-to-end tests under the e2e/ directory
Files:
e2e/solid-start/basic-auth/package.jsone2e/solid-router/basic-file-based/package.jsone2e/solid-router/basic-solid-query-file-based/package.jsone2e/solid-start/scroll-restoration/package.jsone2e/solid-router/basic-virtual-file-based/package.jsone2e/solid-router/basic/package.jsone2e/solid-router/basic-file-based-code-splitting/package.jsone2e/solid-router/basic-solid-query/package.jsone2e/solid-start/spa-mode/package.jsone2e/solid-router/rspack-basic-file-based/package.jsone2e/solid-start/website/package.jsone2e/solid-start/basic-tsr-config/package.jsone2e/solid-start/query-integration/package.jsone2e/solid-start/virtual-routes/package.jsone2e/solid-start/server-routes/package.jsone2e/solid-router/basic-esbuild-file-based/package.jsone2e/solid-start/custom-basepath/package.jsone2e/solid-start/server-functions/package.jsone2e/solid-start/selective-ssr/package.jsone2e/solid-router/basic-virtual-named-export-config-file-based/package.jsone2e/solid-router/rspack-basic-virtual-named-export-config-file-based/package.jsone2e/solid-start/basic/package.jsone2e/solid-router/scroll-restoration-sandbox-vite/package.jsone2e/solid-start/basic-solid-query/package.jsone2e/solid-router/basic-scroll-restoration/package.json
examples/{react,solid}/**
📄 CodeRabbit inference engine (AGENTS.md)
Keep example applications under examples/react/ and examples/solid/
Files:
examples/solid/start-basic-auth/package.jsonexamples/solid/start-basic-cloudflare/package.jsonexamples/solid/start-bare/package.jsonexamples/solid/basic-non-nested-devtools/package.jsonexamples/solid/basic-file-based/package.jsonexamples/solid/basic-devtools-panel/package.jsonexamples/solid/start-basic-nitro/package.jsonexamples/solid/basic-solid-query-file-based/package.jsonexamples/solid/basic/package.jsonexamples/solid/kitchen-sink-solid-query/package.jsonexamples/solid/quickstart-file-based/package.jsonexamples/solid/kitchen-sink-solid-query-file-based/package.jsonexamples/solid/kitchen-sink-file-based/package.jsonexamples/solid/basic-ssr-streaming-file-based/package.jsonexamples/solid/start-basic/package.jsonexamples/solid/start-basic-static/package.jsonexamples/solid/start-basic-solid-query/package.jsonexamples/solid/basic-solid-query/package.jsonexamples/solid/start-basic-netlify/package.json
packages/{router-devtools,*-router-devtools}/**
📄 CodeRabbit inference engine (AGENTS.md)
Keep router devtools packages in packages/router-devtools/ and packages/*-router-devtools/
Files:
packages/solid-router-devtools/package.json
packages/{react-router,solid-router}/**
📄 CodeRabbit inference engine (AGENTS.md)
Implement React and Solid bindings/components only in packages/react-router/ and packages/solid-router/
Files:
packages/solid-router/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (47)
examples/solid/start-basic-nitro/package.json (1)
15-15: LGTM!The solid-js dependency is correctly updated to ^1.9.9, aligning with the PR objective to bump versions across the monorepo.
examples/solid/basic-ssr-streaming-file-based/package.json (1)
23-23: Version bump aligns with PR objective.The solid-js dependency has been correctly updated from ^1.9.5 to ^1.9.9, maintaining backward compatibility while allowing the newer patch versions as intended.
examples/solid/start-basic-netlify/package.json (1)
15-15: LGTM!The
solid-jsversion bump from^1.9.5to^1.9.9is a straightforward patch-level update within the minor version range (1.9.x), ensuring backward compatibility. The change aligns with the PR objective to bump solid-js and align seroval versions across the repository.examples/solid/start-bare/package.json (1)
15-15: Solid-js dependency bump looks good!The version update from ^1.9.5 to ^1.9.9 aligns with the PR objective.
examples/solid/basic-file-based/package.json (1)
17-17: ✓ Solid-js version bump is correct and aligned with PR objectives.The dependency has been updated from ^1.9.5 to ^1.9.9 as intended. The file location adheres to the examples/solid/ directory structure, and no other modifications have affected build behavior or configuration.
examples/solid/start-basic-cloudflare/package.json (1)
18-18: Approve solid-js version bump.The version upgrade from ^1.9.5 to ^1.9.9 is correctly specified and aligns with the PR objectives to align seroval versions. The semver range (^1.9.9) is appropriate for a library bump.
e2e/solid-router/basic/package.json (1)
19-19: LGTM!Version bump from ^1.9.5 to ^1.9.9 is applied correctly, and internal dependencies correctly use the workspace protocol.
e2e/solid-router/basic-file-based/package.json (1)
21-21: LGTM!Version bump applied correctly with proper workspace protocol for internal dependencies.
e2e/solid-router/basic-virtual-file-based/package.json (1)
21-21: LGTM!Version bump applied correctly with proper workspace protocol for internal dependencies.
examples/solid/basic/package.json (1)
17-17: LGTM!Solid-js version bump applied correctly.
e2e/solid-start/spa-mode/package.json (1)
17-17: LGTM!Version bump applied correctly with proper workspace protocol for internal dependencies.
examples/solid/basic-devtools-panel/package.json (1)
17-17: LGTM!Solid-js version bump applied correctly.
examples/solid/start-basic/package.json (1)
16-16: LGTM!Solid-js version bump applied correctly.
examples/solid/start-basic-solid-query/package.json (1)
19-19: LGTM!Solid-js version bump applied correctly.
examples/solid/basic-solid-query/package.json (1)
19-19: Dependency version bump looks good.Updating
solid-jsfrom ^1.9.5 to ^1.9.9 is a safe minor version bump that aligns with the PR objectives.examples/solid/start-basic-static/package.json (1)
16-16: Dependency version bump is consistent across the PR.packages/solid-router-devtools/package.json (1)
73-73: Dependency updates maintain consistency in both dev and peer dependencies.Both
devDependenciesandpeerDependenciesare updated to ^1.9.9, ensuring the devtools package and its consumers use the aligned version. The use ofworkspace:^for internal dependencies follows the coding guidelines.Also applies to: 78-78
examples/solid/basic-solid-query-file-based/package.json (1)
20-20: Dependency version bump is consistent.e2e/solid-router/basic-solid-query-file-based/package.json (1)
22-22: Dependency version bump is consistent and workspace protocol usage is correct.e2e/solid-router/scroll-restoration-sandbox-vite/package.json (1)
24-24: Dependency version bump is consistent.examples/solid/kitchen-sink-solid-query-file-based/package.json (1)
21-21: Dependency version bump is consistent.e2e/solid-router/basic-scroll-restoration/package.json (1)
20-20: Dependency version bump is consistent.e2e/solid-router/basic-virtual-named-export-config-file-based/package.json (1)
21-21: LGTM!Straightforward patch version bump from ^1.9.5 to ^1.9.9, with all internal dependencies correctly using the
workspace:^protocol per coding guidelines.e2e/solid-start/basic-solid-query/package.json (1)
21-21: LGTM!Patch version update (^1.9.5 → ^1.9.9) with all internal dependencies correctly using the
workspace:^protocol.e2e/solid-start/virtual-routes/package.json (1)
19-19: LGTM!Patch version update (^1.9.5 → ^1.9.9) with internal dependencies correctly using the
workspace:^protocol.e2e/solid-start/selective-ssr/package.json (1)
16-16: LGTM!Patch version update (^1.9.5 → ^1.9.9) with internal dependencies correctly using the
workspace:^protocol.packages/solid-start-server/package.json (1)
69-69: LGTM!Patch version update (^1.9.5 → ^1.9.9) in devDependencies. Internal dependencies correctly use the
workspace:*protocol. The peerDependencies requirement (^1.0.0) remains satisfied.e2e/solid-start/website/package.json (1)
18-18: LGTM!Patch version update (^1.9.5 → ^1.9.9) with internal dependencies correctly using the
workspace:^protocol.e2e/solid-start/basic-auth/package.json (1)
21-21: LGTM!Patch version update (^1.9.5 → ^1.9.9) with internal dependencies correctly using the
workspace:^protocol.examples/solid/kitchen-sink-solid-query/package.json (1)
20-20: LGTM!Patch version update (^1.9.5 → ^1.9.9) in this example project. Dependencies are using published versions, which is appropriate for example applications.
e2e/solid-start/basic-tsr-config/package.json (1)
17-17: Clean dependency version bump.The solid-js update from ^1.9.5 to ^1.9.9 is consistent across the repository and aligns with the PR objective to align seroval versions. Internal dependencies correctly use the
workspace:*protocol.e2e/solid-router/basic-file-based-code-splitting/package.json (1)
21-21: Clean dependency version bump.The solid-js update is consistent and properly applied. Internal @tanstack/* dependencies correctly use
workspace:*protocol.examples/solid/basic-non-nested-devtools/package.json (1)
17-17: Dependency update applied correctly.The solid-js version is updated from ^1.9.5 to ^1.9.9. Note: This example file uses absolute version constraints (^1.133.24) for internal @tanstack/* dependencies rather than
workspace:*, which differs from e2e test conventions but may be intentional for released examples.e2e/solid-router/basic-solid-query/package.json (1)
21-21: Clean dependency version bump.The solid-js update is applied consistently. Internal dependencies correctly use
workspace:*protocol.e2e/solid-router/basic-esbuild-file-based/package.json (1)
18-18: Clean dependency version bump.The solid-js update from ^1.9.5 to ^1.9.9 is applied consistently. Internal @tanstack/* dependencies and workspace protocols are correct.
e2e/solid-start/custom-basepath/package.json (1)
18-18: Clean dependency version bump.The solid-js update is consistent and properly applied across this file. Internal dependencies correctly use
workspace:*protocol.e2e/solid-start/server-routes/package.json (1)
19-19: Clean dependency version bump.The solid-js update is applied consistently with the repository changes. Internal dependencies correctly use
workspace:*protocol.examples/solid/start-basic-auth/package.json (1)
19-19: Dependency update applied correctly.The solid-js version is updated from ^1.9.5 to ^1.9.9. As with other example files in this PR, this uses absolute version constraints for internal @tanstack/* dependencies rather than
workspace:*.e2e/solid-router/rspack-basic-virtual-named-export-config-file-based/package.json (1)
16-16: Version bump is consistent with PR objective.The solid-js dependency update from ^1.9.5 to ^1.9.9 aligns with the PR goal to align seroval versions. No other changes to dependencies or configuration.
examples/solid/kitchen-sink-file-based/package.json (1)
18-18: Version bump applied correctly.The solid-js dependency is updated from ^1.9.5 to ^1.9.9 as intended. No other changes.
e2e/solid-router/rspack-basic-file-based/package.json (1)
16-16: Version bump is appropriate.solid-js dependency updated from ^1.9.5 to ^1.9.9 to align with seroval versions, as intended.
e2e/solid-start/scroll-restoration/package.json (1)
19-19: Version bump consistent with PR objective.solid-js dependency updated from ^1.9.5 to ^1.9.9. No other modifications.
e2e/solid-start/basic/package.json (1)
24-24: Version bump aligns with PR intent.solid-js dependency updated from ^1.9.5 to ^1.9.9 to align seroval versions. Build and test scripts remain unchanged.
e2e/solid-start/query-integration/package.json (1)
20-20: Version bump appropriate for this e2e suite.solid-js dependency updated from ^1.9.5 to ^1.9.9 without affecting other dependencies or scripts.
e2e/solid-start/server-functions/package.json (1)
19-19: Version bump is correct.solid-js dependency updated from ^1.9.5 to ^1.9.9 as part of the PR's seroval alignment effort.
packages/solid-router-ssr-query/package.json (1)
73-73: Version bump correctly applied to both devDependencies and peerDependencies.solid-js updated from ^1.9.5 to ^1.9.9 in both scopes (lines 73 and 80), ensuring consistency for this core package. Consumers will correctly understand the supported solid-js version range.
Also applies to: 80-80
packages/solid-router/package.json (1)
116-116: Consistent version bump across devDependencies and peerDependencies.Both constraints updated to
^1.9.9uniformly, ensuring package consumers and developers have aligned solid-js versions.Also applies to: 121-121
| }, | ||
| "devDependencies": { | ||
| "solid-js": "^1.9.5", | ||
| "solid-js": "^1.9.9", |
There was a problem hiding this comment.
Update peerDependencies to match devDependencies version constraint.
The devDependencies are bumped to ^1.9.9, but peerDependencies remain at >=1.9.5. This inconsistency allows consumers to install incompatible solid-js versions and creates potential runtime mismatches. Align peerDependencies to ^1.9.9 for the intended upgrade.
"peerDependencies": {
"@tanstack/router-core": "workspace:^",
- "solid-js": ">=1.9.5",
+ "solid-js": "^1.9.9",
"tiny-invariant": "^1.3.3"
},Also applies to: 76-76
🤖 Prompt for AI Agents
packages/router-devtools-core/package.json lines 70 and 76: peerDependencies for
solid-js are still set to ">=1.9.5" while devDependencies were bumped to
"^1.9.9"; update the peerDependencies entries to use the same version constraint
"^1.9.9" so peer and dev constraints align and consumers cannot install an
incompatible solid-js version.
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-router-ssr-query
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Use workspace:* protocol for internal dependencies in package.json files
Files:
package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
solid-js@1.9.5 uses seroval@1.2.0
TanStack Router/Start uses seroval@1.3.2
Upgrading to solid-js@1.9.9 makes solid compatible with seroval ~1.3
Summary by CodeRabbit