test(solid-router): sync unit tests from react-router #5614

birkskyum · 2025-10-25T17:15:15Z

Summary by CodeRabbit

Release Notes

New Features
- Added getRouteApi, createMemoryHistory, and useRouter to the Solid Router public API
- Enhanced support for optional path parameters across routing scenarios
- Improved basepath handling and URL rewriting capabilities
Tests
- Expanded test coverage for navigation, parameter handling, not-found routing, and state management during navigation flows

coderabbitai · 2025-10-25T17:15:27Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between a068c43 and 3543fb6.

📒 Files selected for processing (9)

packages/react-router/tests/useNavigate.test.tsx (0 hunks)
packages/solid-router/tests/link.test.tsx (5 hunks)
packages/solid-router/tests/loaders.test.tsx (2 hunks)
packages/solid-router/tests/navigate.test.tsx (1 hunks)
packages/solid-router/tests/not-found.test.tsx (1 hunks)
packages/solid-router/tests/optional-path-params.test-d.tsx (1 hunks)
packages/solid-router/tests/optional-path-params.test.tsx (1 hunks)
packages/solid-router/tests/router.test.tsx (2 hunks)
packages/solid-router/tests/store-updates-during-navigation.test.tsx (1 hunks)

 ____________________________________________________________________
< There is a 100% chance that this message is relevant to your code. >
 --------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch sync-solid-router-tests-from-react

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2025-10-25T17:15:51Z

View your CI Pipeline Execution ↗ for commit 3543fb6

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	2m 14s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2025-10-25 17:20:03 UTC

pkg-pr-new · 2025-10-25T17:18:26Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5614

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5614

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5614

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5614

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5614

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5614

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5614

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5614

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5614

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5614

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5614

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5614

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5614

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5614

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5614

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5614

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5614

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5614

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5614

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5614

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5614

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5614

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5614

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5614

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5614

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5614

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5614

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5614

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5614

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5614

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5614

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5614

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5614

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5614

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5614

commit: 3543fb6

birkskyum added 3 commits October 25, 2025 18:39

port tests

cbc1e81

make optional path param work

92d11f6

test(solid-router): sync unit tests from react-router

f9de900

github-actions bot added package: react-router package: solid-router labels Oct 25, 2025

ci: apply automated fixes

3543fb6

birkskyum merged commit f4a544f into main Oct 25, 2025
5 of 6 checks passed

birkskyum deleted the sync-solid-router-tests-from-react branch October 25, 2025 17:21

birkskyum added this to the catch up solid to react milestone Oct 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

test(solid-router): sync unit tests from react-router #5614

test(solid-router): sync unit tests from react-router #5614

Uh oh!

birkskyum commented Oct 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 25, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Oct 25, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Oct 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

test(solid-router): sync unit tests from react-router #5614

test(solid-router): sync unit tests from react-router #5614

Uh oh!

Conversation

birkskyum commented Oct 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Release Notes

Uh oh!

coderabbitai bot commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud bot commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Oct 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

birkskyum commented Oct 25, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 25, 2025 •

edited

Loading

nx-cloud bot commented Oct 25, 2025 •

edited

Loading