Skip to content

test(solid-router): sync unit tests from react-router #5614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 25, 2025
Merged

test(solid-router): sync unit tests from react-router #5614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbc1e81
port tests
birkskyum Oct 25, 2025
92d11f6
make optional path param work
birkskyum Oct 25, 2025
f9de900
test(solid-router): sync unit tests from react-router
birkskyum Oct 25, 2025
3543fb6
ci: apply automated fixes
autofix-ci[bot] Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions packages/react-router/tests/useNavigate.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2520,24 +2520,6 @@ describe.each([{ basepath: '' }, { basepath: '/basepath' }])(
expect(window.location.pathname).toBe(`${basepath}/param/foo/a`)
})

test('should navigate to a parent link based on active location', async () => {
const router = setupRouter()

render(<RouterProvider router={router} />)

await act(async () => {
history.push(`${basepath}/param/foo/a/b`)
})

const relativeLink = await screen.findByTestId('link-to-previous')

// Click the link and ensure the new location
fireEvent.click(relativeLink)
await router.latestLoadPromise

expect(window.location.pathname).toBe(`${basepath}/param/foo/a`)
})

test('should navigate to same route with different params', async () => {
const router = setupRouter()

Expand Down
Loading
Loading