fix: check for row existence in handleRowById #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @tannerlinsley on Vercel. @tannerlinsley first needs to authorize it. |
|
this looks great! i notice that this pr has been open for a long time, and now there's a similar pr that applies the same fix plus some unit tests: #3440 |
|
@jschen2 hi any updates here? |
|
Will merge this if we can get the conflicts resolved. |
|
Changed to the correct base (v7) to remove conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the errors referenced by #2833 and #3071. This will also fix a "TypeError: Cannot read property 'subRows' of undefined" error. These errors appear when a row does not exist, whether removed from the data or filtered out, but there is still a reference in the selected state.