fix(useRowSelect): do not throw if toggleRowSelected id not found in current instance #3440
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @tannerlinsley on Vercel. @tannerlinsley first needs to authorize it. |
| @@ -153,6 +153,7 @@ function reducer(state, action, previousState, instance) { | |||
|
|
|||
| const handleRowById = id => { | |||
| const row = rowsById[id] | |||
| if (row === undefined) return | |||
There was a problem hiding this comment.
from looking through some other files, i think it might be a repo convention to include the { } like this:
| if (row === undefined) return | |
| if (row === undefined) { | |
| return | |
| } |
| describe('reducer', () => { | ||
| describe('toggleRowSelected', () => { | ||
| test('does not throw when row not found', () => { |
|
what's the status of this PR? is it going to be merged anytime soon? |
|
+1 we are looking to have this fixed for our implementation as well |
|
This pull request is being marked as stale (no activity in the last 14 days) |
|
This pull request has been detected as stale (no activity in the last 14 days) and automatically closed. It's very likely that your pull request has remained here this long because it introduces breaking changes to the v7 API. React Table v8 is currently in alpha (soon beta!) and already contains bug fixes, performance improvements and architectural changes that likely address the issue this pull request is meant to solve.
|
Encountered an exception when a component callback held reference to a row that was deleted by the time it was executed. This PR adds a small change to bail early in the reducer if the
toggleRowSelectedaction's row id is not found in the current instance.