Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getIsSomeRowsSelected on all selection #5499

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −14
Open

fix: getIsSomeRowsSelected on all selection #5499

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d9e4e7
fix: getIsSomeRowsSelected on all selection
iamswain25 Apr 19, 2024
e42f9dd
Merge branch 'main' into fix/getIsSomeRowsSelected-on-all
KevinVandy Jun 30, 2024
a0f1cc3
getIsSomeRowsSelected should not return false when all rows are selected
KevinVandy Jun 30, 2024
c6fbd9a
Merge branch 'main' into fix/getIsSomeRowsSelected-on-all
iamswain25 Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/table-core/src/features/RowSelection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ export const RowSelection: TableFeature = {
).length
return (
totalSelected > 0 &&
totalSelected < table.getFilteredRowModel().flatRows.length
totalSelected <= table.getFilteredRowModel().flatRows.length
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct fix. We should just get rid of all the logic that returns false if all rows are selected.

)
}

Expand Down