fix: getIsSomeRowsSelected on all selection #5499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamswain25
force-pushed
the
fix/getIsSomeRowsSelected-on-all
branch
from
924383b to
1d9e4e7
Compare
|
Is it possible to get this merged? The documentation already states that this is how the row selection check should work! |
1 task
KevinVandy
reviewed
Jun 30, 2024
| @@ -436,7 +436,7 @@ export const RowSelection: TableFeature = { | |||
| ).length | |||
| return ( | |||
| totalSelected > 0 && | |||
| totalSelected < table.getFilteredRowModel().flatRows.length | |||
| totalSelected <= table.getFilteredRowModel().flatRows.length | |||
There was a problem hiding this comment.
This is not the correct fix. We should just get rid of all the logic that returns false if all rows are selected.
|
To truly fix this I think some breaking changes might be needed. I'm going to point this PR to the alpha branch probably |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a0f1cc3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selecting all rows and run
getIsSomeRowsSelected, it returnfalseinstead oftrue.