Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/#73] 로그아웃 API 연결 #76

Merged
merged 15 commits into from
Jul 18, 2023
Merged

[Feat/#73] 로그아웃 API 연결 #76

merged 15 commits into from
Jul 18, 2023

Conversation

ss99x2002
Copy link
Member

🎀 Related Issues

close #73

🤔 What Did You Do

  • 로그아웃 API 연결 (200 뜸)
  • 로그아웃 성공시 히스토리 지우고, 로그인 Activity로 넘어가도록 완

⁉️ etc

  • SharedPreference 처리는 로그인 성공 후에 합시다.

@ss99x2002 ss99x2002 self-assigned this Jul 17, 2023
@ss99x2002 ss99x2002 added feature 기능 개발 서현 labels Jul 17, 2023
Copy link
Contributor

@yeoncheong yeoncheong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!
로그인 로그아웃 한번에 붙이는 엄빠 안드 어떤데

Comment on lines +7 to +8
@PATCH("/log-out")
suspend fun logout(): LogOutResponseDto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

폼 미쳤다...

Comment on lines +14 to 27
fun logout(): Int? {
viewModelScope.launch {
settingRepositoryImpl.logout()
.onSuccess { response ->
Log.e("hyeon", "logout 성공")
responseStatus.value = response.status
}.onFailure { error ->
Log.e("hyeon", "logout 실패 " + error.message)
responseStatus.value = -1
}
}
return responseStatus.value
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하다.... 역시 안드 리드

@@ -32,7 +32,7 @@
android:id="@+id/layout_appbar"
layout="@layout/qna_appbar"
app:clickListener="@{clickListener}"
app:titleText="@{` `}"
app:titleText="@{vm.isBeforeList ? vm.listQnaResponse.section : vm.qnaResponse.section}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

데이터바인딩 적용 굿입니다 👍👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

시간 있으면 다른것들도 다 데이터바인딩으로 바꾸겠습니더

@ss99x2002 ss99x2002 merged commit 3c17f71 into develop Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 기능 개발 서현
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 로그아웃 API 연결
2 participants