-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat/#73] 로그아웃 API 연결 #76
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6c60c11
[Design/#73] recycler view 맨 아래 짤림 문제 해결
ss99x2002 de2242a
[Design/#73] 리스트 이미지 크기 변경
ss99x2002 c5c8193
[Feat/#73] 알림 on/off 설정 기능 추가
ss99x2002 57b6689
[Fix/#73] appbar 글자 오류 해결
ss99x2002 5a7301a
[Feat/#73] 답변 후 문답화면으로 넘어가기 기능 추가
ss99x2002 65337d4
[Refac/#73] .toLong -> L 변경
ss99x2002 2fd23aa
[Refac/#73] isBeforeList 변수 추가
ss99x2002 c866c1f
[Refac/#73] responseDto 수정사항 반영
ss99x2002 5f4a189
[Feat/#73] Logout ResponseDto 추가
ss99x2002 c4171c3
[Del/#73] main getToken() 함수 지우기
ss99x2002 8b778e3
[Feat/#73] setting 서비스 추가
ss99x2002 c87efba
[Feat/#73] setting 서비스 추가
ss99x2002 e7267d7
[Feat/#73] viewModel Factory 추가
ss99x2002 204f88e
[Feat/#73] 로그아웃 api 연결
ss99x2002 bd7c08c
Merge branch 'develop' into feat/#73
ss99x2002 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
app/src/main/java/com/sopt/umbba_android/data/model/response/LogOutResponseDto.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package com.sopt.umbba_android.data.model.response | ||
|
||
import kotlinx.serialization.SerialName | ||
import kotlinx.serialization.Serializable | ||
|
||
@Serializable | ||
data class LogOutResponseDto( | ||
@SerialName("status") | ||
val status: Int, | ||
@SerialName("message") | ||
val message: String | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 10 additions & 3 deletions
13
app/src/main/java/com/sopt/umbba_android/data/repository/SettingRepositoryImpl.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 5 additions & 1 deletion
6
app/src/main/java/com/sopt/umbba_android/data/service/SettingService.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
package com.sopt.umbba_android.data.service | ||
|
||
import com.sopt.umbba_android.data.model.response.LogOutResponseDto | ||
import retrofit2.http.PATCH | ||
|
||
interface SettingService { | ||
suspend fun logout() | ||
@PATCH("/log-out") | ||
suspend fun logout(): LogOutResponseDto | ||
suspend fun deleteAccount() | ||
} |
4 changes: 3 additions & 1 deletion
4
app/src/main/java/com/sopt/umbba_android/domain/repository/SettingRepository.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,8 @@ | ||
package com.sopt.umbba_android.domain.repository | ||
|
||
import com.sopt.umbba_android.data.model.response.LogOutResponseDto | ||
|
||
interface SettingRepository { | ||
suspend fun logout() | ||
suspend fun logout():Result<LogOutResponseDto> | ||
suspend fun deleteAccount() | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
app/src/main/java/com/sopt/umbba_android/presentation/setting/SettingFragment.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 13 additions & 1 deletion
14
...main/java/com/sopt/umbba_android/presentation/setting/viewmodel/ManageAccountViewModel.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,27 @@ | ||
package com.sopt.umbba_android.presentation.setting.viewmodel | ||
|
||
import android.util.Log | ||
import androidx.lifecycle.MutableLiveData | ||
import androidx.lifecycle.ViewModel | ||
import androidx.lifecycle.viewModelScope | ||
import com.sopt.umbba_android.data.repository.SettingRepositoryImpl | ||
import kotlinx.coroutines.launch | ||
|
||
class ManageAccountViewModel(private val settingRepositoryImpl: SettingRepositoryImpl) : | ||
ViewModel() { | ||
fun logout() { | ||
|
||
var responseStatus = MutableLiveData<Int>() | ||
fun logout(): Int? { | ||
viewModelScope.launch { | ||
settingRepositoryImpl.logout() | ||
.onSuccess { response -> | ||
Log.e("hyeon", "logout 성공") | ||
responseStatus.value = response.status | ||
}.onFailure { error -> | ||
Log.e("hyeon", "logout 실패 " + error.message) | ||
responseStatus.value = -1 | ||
} | ||
} | ||
return responseStatus.value | ||
} | ||
} | ||
Comment on lines
+14
to
27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 깔끔하다.... 역시 안드 리드 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,7 +32,7 @@ | |
android:id="@+id/layout_appbar" | ||
layout="@layout/qna_appbar" | ||
app:clickListener="@{clickListener}" | ||
app:titleText="@{` `}" | ||
app:titleText="@{vm.isBeforeList ? vm.listQnaResponse.section : vm.qnaResponse.section}" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 데이터바인딩 적용 굿입니다 👍👍 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 시간 있으면 다른것들도 다 데이터바인딩으로 바꾸겠습니더 |
||
app:visibleCheck="@{false}" /> | ||
|
||
<TextView | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
폼 미쳤다...