Can't interact with app/screen below popup player on Android 12

[Joristdh]

Checklist

• I am using the latest version - 0.21.7
• I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
• I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
• This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

0. This is a bug on Android 12 beta 3
1. Open a video in the popup player (it doesn't matter which video or how you open it)
2. Make sure the popup uses the full width of the screen (when in portrait)
3. Open another app below the popup player, go to the home screen or open recent apps
4. Try to interact with the screen below the popup

Actual behavior

All touches to the app/screen below the popup are ignored, because of the following behavior change in Android 12: https://developer.android.com/about/versions/12/behavior-changes-all#untrusted-touch-events

Expected behavior

The app below the popup responds to the touches.

Workaround

For now this issues can be solved per device by running the following ADB command:
adb shell settings put global block_untrusted_touches 0

Device info

• Android version/Custom ROM version: Android 12 beta 3
• Device model: Pixel 3

[chrstfer]

Im seeing this sporadically on android 11 (samsung gs20 ultra with up to date stock firmware) with most recent release (0.21.7). It doesn't seem to matter about the fullwidth thing, though iwill start to pay attention if that is triggering it and then the issue is persisting after i make it smaller again.

Also, often the app beneath will respond to drags and swipes but no controls will send their events even though they animate.

This might be because certain apps are supporting new APIs? Or it might be a different but similar bug.

[chrstfer]

What needs to be done to fix this? Its real annoying to need to clear my queue (because of an unrelated issue) just to send a tweet.

[Joristdh]

@chrstfer I don't think it is the same bug. The behavior change is introduced in Android 12, as you can see in the link I provided in the description. If you encounter a similar bug in Android 11 it's probably caused by something else.
Maybe Samsung implemented a similar restriction in One UI or those apps implemented some restrictions themselves (for while another app overlays them).

If your bug does have the same cause, the ADB shell command in the description should fix it. If it doesn't, or you can't execute the command at all (because you aren't on Android 12), you should probably file a new bug report detailing your specific issue.

[hackel]

I also (still) have this issue on Android 12 beta 4.1 and the width of the pop-up makes no difference. I believe I read that the native PIP mode will need to be used going forward for security.

Update: Still broken in Android 12 final, as expected (sadly).

[captainhook]

I am also seeing this on Pixel 5, Android 12.

I'm not keen on the security implications of the workaround, so I'll wait for PiP implementation, but I can confirm it works.

[Joristdh]

It is also possible to only exclude NewPipe from this new permission:
adb shell am compat disable BLOCK_UNTRUSTED_TOUCHES org.schabi.newpipe

I haven't tested this myself, but this should allow you to only disable this restriction for the NewPipe overlay

[captainhook]

>adb shell am compat disable BLOCK_UNTRUSTED_TOUCHES org.schabi.newpipe
Cannot override a change on a non-debuggable app and user build.

Seems to not work for this.
It is documented here though so good thinking: https://developer.android.com/about/versions/12/behavior-changes-all?hl=ro#untrusted-touch-events

[schnatzi]

Same thing on Pixel 6 with Android 12.0. Oddly enough the problem wasn't an issue on the Pixel 3 with Android 12 at my end.

[dbenjaminmiller]

Can confirm this is an issue for me on Android 12. What I think would be the proper solution is to offer a native popup as the default for A12 users with the old-style popup available as an option (which would require ADB access to be useful).

[asdf512]

#2223 Is the current open issue for implementing PiP support. Others date back to 2017. Hopefully with the recent problems caused by android 12 this will be resolved.

[Coderdude112]

@schnatzi You arn't having problems with it on your Pixel 3? I'm having problems on my Pixel 3...

[schnatzi]

@schnatzi You aren't having problems with it on your Pixel 3? I'm having problems on my Pixel 3...

Maybe it just didn't occur at my end, because I didn't use it in combination with other apps since the update.

[codingicebear]

Can confirm this. When in pop up player mode, screen below the player becomes unresponsive.

A12 latest build

[PacoBell]

adb shell am compat disable BLOCK_UNTRUSTED_TOUCHES org.schabi.newpipe
Cannot override a change on a non-debuggable app and user build.

Seems to not work for this. It is documented here though so good thinking: https://developer.android.com/about/versions/12/behavior-changes-all?hl=ro#untrusted-touch-events

Yes, the specifically targeted app workaround doesn't work, but the global one does:

adb shell settings put global block_untrusted_touches 0

Just FYI 😉

[Coderdude112]

Thanks @PacoBell! Worked immediately

[rawlife56]

The security measure exists for a reason. It is not smart enough to disable it globally.

[Coderdude112]

@rawlife56 Yes, it does exist for a reason, I believe there is an application for it. It's new with Android 12 to my knowledge and not many apps have been updated to work with the new permissions. Pip is a useful feature and is something I use all the time, so this temporary fix is ok.

[book000]

This issue also occurs on Pixel 3a, Android 12.
Moreover, it seems to occur even when playing in the background... (There is a notification in the notification column that "NewPipe is displayed above other apps")
If you stop NewPipe playing in the background from the notification column as it is, in the worst case you will not be able to operate Home or other applications.

[werjany]

Please test #8045. It's not the optimal solution at all, but should really help you until the player rewrite is done.

After the newest update to MIUI 13 that solution doesn't work at all. Cannot use a popup window - the phone doesn't respond to touching anywhere else.

[moneytoo]

This must be just some fixable issue as other video players using overlay window API (not the PiP) work just fine on Android 12 (Samsung Galaxy S21 FE). For example Nova Video Player or (when configured to use overlay window instead of native PiP) MX Player and OPlayer. I will try debugging that when I have some time.
EDIT: Could it be because of FLAG_NOT_TOUCHABLE in the overlay drop zone for closing the popup?

[AudricV]

I made some tests and the non interaction of the screen on Android 12 is definitively caused by the close popup view button! By preventing its construction on Android 12+, other apps can get touches made to the screen.

However, several things in the player are based on this button, and just prevent the creation of this button crashes the app when resizing or moving the view. So, if the solution to this issue is to disable this button, at least for Android 12+, code using the close popup button will need to be updated.

[AudricV]

So, if the solution to this issue is to disable this button, at least for Android 12+, code using the close popup button will need to be updated.

I did it and the issue seems to be gone, at least on my emulator (Pixel 5 running Android 12).

However, I can't test the resize gesture.

Could you test this gesture and everything else with the popup player, using the following APK to see if I didn't break something with my changes (you can find them here: https://github.com/TiA4f8R/NewPipe/tree/disable-close-popup-button-creation-android-12-and-higher)? Thank you in advance!

app-debug.zip

[werjany]

made some tests and the non interaction of the screen on Android 12 is definitively caused by the close popup view button! By preventing its construction on Android 12+, other apps can get touches made to the screen.

However, several things in the player are based on this button, and just prevent the creation of this button crashes the app when resizing or moving the view. So, if the solution to this issue is to disable this button, at least for Android 12+, code using the close popup button will need to be updated.

I tried using your update. Didn't solve the problem (Xiaomi Mi Note 10 Lite, MIUI 13.0.1, Android 12). It is still impossible to use the overlaying window outside the app, nothing except bottom buttons, notifications and control centre interacts.

[moneytoo]

I did it and the issue seems to be gone, at least on my emulator (Pixel 5 running Android 12).

However, I can't test the resize gesture.

FYI: It is possible to use pinch to zoom (using standard mouse) in the emulator. There's some "secret" key combination to se the wanted initial zones for the gesture (last time I needed this I found the answer on StackOverflow).

Could you test this gesture and everything else with the popup player, using the following APK to see if I didn't break something with my changes (you can find them here: https://github.com/TiA4f8R/NewPipe/tree/disable-close-popup-button-creation-android-12-and-higher)? Thank you in advance!

Works for me seemingly fine on Android 12 (Samsung Galaxy S21 FE) including the window resize.

[vnckppl]

Running the fix on my Samsung a53 stock without any issues. Watching a video in popup mode while typing this comment.

[AudricV]

@moneytoo @vnckppl Sorry to ping you, but could you also test this APK and see if the issue is gone too?

It seems when setting a lower opacity to the close button (up to 0.8), we can also use the popup player on Android 12 and higher.

Could you test the following changes to see if they work (the source code is available here)? Thank you!

app-debug.zip

[moneytoo]

@TiA4f8R The attached build works perfectly for me when using the popup player.

[werjany]

@moneytoo @vnckppl Sorry to ping you, but could you also test this APK and see if the issue is gone too?

It seems when setting a lower opacity to the close button (up to 0.8), we can also use the popup player on Android 12 and higher.

Could you test the following changes to see if they work (the source code is available here)? Thank you!

app-debug.zip

That works for me too! Thanks!

[book000]

The build posted by @TiA4f8R confirms that the popups work as expected! (Pixel 3a / Android 12)
Thank you.

[alexsohn1126]

@moneytoo @vnckppl Sorry to ping you, but could you also test this APK and see if the issue is gone too?

It seems when setting a lower opacity to the close button (up to 0.8), we can also use the popup player on Android 12 and higher.

Could you test the following changes to see if they work (the source code is available here)? Thank you!

app-debug.zip

Amazing. Worked for me.
Using Galaxy S10+ with Android 12.

[vnckppl]

@moneytoo @vnckppl Sorry to ping you, but could you also test this APK and see if the issue is gone too?

It seems when setting a lower opacity to the close button (up to 0.8), we can also use the popup player on Android 12 and higher.

Could you test the following changes to see if they work (the source code is available here)? Thank you!

app-debug.zip

Works great! I can navigate normally in underlying apps and dragging the popup window to the closing button works too.

[AudricV]

This bug should have been fixed by #8279, included in the upcoming release, 0.23.0. Closing as resolved.