changed dark theme colors to darker variant

[sauravrao637]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)
• UI improvement

Description of the changes in your PR

improved dark_youtube_primary_color and dark_youtube_dark_color

Fixes the following issue(s)

• Fixes Whe using dark mode, change the color of red elements so they have a dark pale shade of red #6203

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

• I read the contribution guidelines.

[iamthesenate1]

Hi! I installed it and I think it looks good but I noticed a mismatch betwen the titlebar color and the color of the notification bar (it is the old, brighter one).

[iamthesenate1]

Also, in the settings menu (almost) the same thing happens, but in reverse.

[sauravrao637]

@iamthesenate1 Thanks for pointing out :)
I have done the missed changes now

[peat80]

This should probably be done with the other services colours too and then included as a separate theme to choose in settings. 🤔

[iamthesenate1]

It works better now but in the settigs menu there is still a mismatch. Is this intended?

[iamthesenate1]

This should probably be done with the other services colours too and then included as a separate theme to choose in settings. 🤔

I agree

[ghost]

Great! :D

Looks way better, congrats! The statusbar background color could be black, with opacity, because is still showing the red vivid color:

Another possible solution would be a transparent top panel, following Material Design 2 guidelines (for example, YouTube and Play Store ditched the red and the green background in the top panel).

Also, the splash screen is showing the vivid red, maybe its background could follow the system theme instead of being red.

[sauravrao637]

I am closing this PR as #6272 will provide better solution

[Stypox]

No @sauravrao637, this is a good idea, while #6272 is probably not doable at all.

The color of Android's top bar should be made the same as the toolbar.

[sauravrao637]

@Stypox
Okay I'll do it when I get some time these weeks busy with something else (sorry for this).😔

[sauravrao637]

@Stypox I've done done the changes and you can now check them and suggest the changes if needed or merge it :)

[Stypox]

Looks mostly good to me ;-)

[OutshineIssue]

Can we add a full black top bar when on "black" mode theme?

[Stypox]

Great, thank you! :-)

[sauravrao637]

@Stypox
I think this can be merged and closed now.

[Stypox]

@TeamNewPipe/all do we want to merge this?

[Poolitzer]

Since I am in the team somehow and you pinged the whole team, yep, merge it, I like that change.

[opusforlife2]

Can we have some screenshots for the updated code?

Edit: Also, @sauravrao637 please use a better title for the PR that describes the change in the UI, not which XML attributes were affected.

[sauravrao637]

@opusforlife2
Here are few screenshots, hope you like it :)

[opusforlife2]

I like it! Thanks for this! The muted colours look very nice. Now I'm comparing this to the current release and the bright red kind of hurts the eyes.

[sauravrao637]

So is this now finally ready to be merged?
:)

[opusforlife2]

@sauravrao637 Thanks! The muted colours look great in the latest debug APKs I'm using. But now the splash screen also looks too bright.

Is it possible to use a darkened splash screen with the dark theme?

[sauravrao637]

@opusforlife2 Unfortunately the splash screen cannot depend on the in app preferences because it is loaded before app is in memory so we cannot make multiple theme specific splash screens but what we can do instead is that we can use system preferences that is when the system is in night mode we can load a darker variant.
In easy and short terms we can implement it for when the system is running in night mode irrespective of the user's settings for theme in New Pipe.
We can also do the custom splash screens for multiple themes but there's only UGLY way (making splash activity and defeating the real purpose of splash screen) to do so.

[opusforlife2]

@sauravrao637 Indeed. I was thinking about the Play Store splash screen when I suggested it. You're right that this depends on the OS theme, not app theme.

[opusforlife2]

@rahaaatul If your reasoning is the same as in the linked issue, then there is no point. If it is different, then you'll need to open a new issue anyway with your new reasoning.