Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fullscreen sometimes show a quarter of a screen [Android 12] #7262

Closed
4 tasks done
privacyonly opened this issue Oct 16, 2021 · 78 comments · Fixed by #8170
Closed
4 tasks done

Fullscreen sometimes show a quarter of a screen [Android 12] #7262

privacyonly opened this issue Oct 16, 2021 · 78 comments · Fixed by #8170
Labels
bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software help wanted Help is wanted in fixing this issue player Issues related to any player (main, popup and background)

Comments

@privacyonly
Copy link

privacyonly commented Oct 16, 2021 •
edited by litetex
Loading

ℹ️ Please don't leave a comment like "I am having the same issue" without additional information. Simply upvote the issue instead.

Checklist

Steps to reproduce the bug

  1. open new pipe
  2. press on any videos
  3. press play
  4. press on the full screen

Actual behavior

it is a quarter of full screen on the top left corner of the screen

Expected behavior

full screen

Screenshots/Screen recordings

https://player.vimeo.com/video/633798373

Logs

Device info

  • Android version/Custom ROM version: Android 12 OneUI 4.0 beta 2 official ZUJ1
  • Device model: SM-G998B Samsung Galaxy S21 Ultra 5G
@privacyonly privacyonly added the bug Issue is related to a bug label Oct 16, 2021
@triallax triallax added the player Issues related to any player (main, popup and background) label Oct 21, 2021
@litetex
Copy link
Member

litetex commented Oct 22, 2021

I didn't observe the problem so far so I assume it's somewhat device or software specific.

@litetex litetex added the device/software specific Issues that only happen on some devices or with some specific hardware/software label Oct 22, 2021
@opusforlife2

This comment has been minimized.

Sign in to view
@privacyonly
Copy link
Author

so I updated to the latest beta, Android 12 OneUI 4.0 beta 3 ZUJG, it is not fixed

does this happen to other software?
samsung video player no
vlc it doesn't have the button.

is it just slow to change from quarter to full screen?
no it is not slow, but it stuck at quarter of full screen.

is S21 Ultra included in "old Device"? I don't think so

@opusforlife2

This comment has been minimized.

Sign in to view
@litetex
Copy link
Member

litetex commented Oct 23, 2021

Android 12 OneUI 4.0 beta 3

Is the bug also present outside of the beta?
Maybe it's a problem because the OS is "beta".

@privacyonly
Copy link
Author

privacyonly commented Oct 24, 2021 •
edited
Loading

no the bug is not present on Samsung S21 Ultra Android 11 OneUI 3.1 A1HD

I also have 5 other Samsung Android 11 Oneui 3.0 device and 1 emui 10 which does not have this problem.

I just don't know if the bug exist on other android 12 device like google pixel.

edit: google pixel instead of pixel 6.

@diogodh

This comment has been minimized.

Sign in to view
@efb4f5ff-1298-471a-8973-3d47447115dc

This comment has been minimized.

Sign in to view
@ghost
Copy link

ghost commented Oct 27, 2021

I also have this issue on the Pixel 5 running Android 12 with GrapheneOS

@privacyonly
Copy link
Author

privacyonly commented Oct 29, 2021 •
edited
Loading

try
settings > video and audio > turn on start main player in fullscreen.

does it always go to full screen after starting?

I know it will sometimes still show a quarter if we go back and forth using the full screen button.

edit:
I don't have any Android 12 tablet but, I suspect Android 12 tablet doesn't have the same problem,
can anyone please try if their android 12 tablet have the same problem?

@litetex litetex mentioned this issue Nov 1, 2021
Closed
4 tasks
@litetex litetex changed the title Fullscreen sometimes show a quarter of a screen Fullscreen sometimes show a quarter of a screen [Android 12] Nov 3, 2021
@litetex
Copy link
Member

litetex commented Nov 3, 2021

Maybe #7005 (this PR updates ExoPlayer) solves this problem.

@Coderdude112

This comment has been minimized.

Sign in to view
@opusforlife2
Copy link
Collaborator

@Coderdude112 Did you try the APK suggested in the comment above yours?

@Coderdude112
Copy link

Not yet, ill give it a try today

@Sagittarisus
Copy link

Maybe #7005 (this PR updates ExoPlayer) solves this problem.

Tested apk seems to have solved the issue

@litetex litetex mentioned this issue Nov 7, 2021
Merged
5 tasks
@litetex litetex mentioned this issue Nov 21, 2021
Closed
4 tasks
@privacyonly

This comment has been minimized.

Sign in to view
@Sagittarisus
Copy link

Experiencing the same issue, something caused it to break inside of the latest build, it was fixed when exoplayer was updated before.

@Fexiven Fexiven mentioned this issue Dec 20, 2021
Closed
@litetex litetex mentioned this issue Dec 29, 2021
Closed
4 tasks
@xelaseer

This comment has been minimized.

Sign in to view
@VinnyVynce

This comment has been minimized.

Sign in to view
@Sagittarisus
Copy link

I was able to compile the newpipe app from source code, and one of the commits which were done after the official newest release has fixed the issue as I do not experience it any more.

@litetex
Copy link
Member

litetex commented Jan 9, 2022

I was able to compile the newpipe app from source code

You can also use the latest CI build of the dev branch:
Currently:

However we didn't fix something player-specific - at least of what I'm aware of.
Maybe #7499 fixed it? ¯\_(ツ)_/¯

@privacyonly
Copy link
Author

can someone please try the apk above and give a feedback?

privacyonly added a commit to privacyonly/NewPipe-Close-7262 that referenced this issue Jun 28, 2022
@privacyonly
Update Player.java
fa55180 
Try fix TeamNewPipe#7262
@privacyonly privacyonly mentioned this issue Jun 28, 2022
Closed
5 tasks
@Outlet2048
Copy link

Outlet2048 commented Jun 28, 2022 •
edited by github-actions bot
Loading

can someone please try the apk above and give a feedback?

Screenshot_2022-06-28-13-52-09-64_3d73e98b1ad3bd2575f7a56513d89a0c.jpg

@AndyP435

This comment was marked as duplicate.

Sign in to view
@StefMarko

This comment was marked as duplicate.

Sign in to view
@barackenkumpel
Copy link

did it fix this problem?

Yes, very well.
But the Overlay behaves kinda flashy now

Screen_Recording_20220708-135528_NewPipe.Debug.mp4

@AudricV AudricV pinned this issue Jul 11, 2022
@AudricV AudricV mentioned this issue Jul 11, 2022
Closed
5 tasks
@Donkey-Doug
Copy link

I didn't observe the problem so far so I assume it's somewhat device or software specific.

I have had this issue for a very long time. I believe it happens when a video is still loading (video fully black) and I press maximize. In my case, however, it is always half the screen and not a quarter.

Android 10
Xiaomi mi 9t pro
Lineageos without google

@Outlet2048
Copy link

Half the screen happens when you have your video size set to "fill" I think
At least either of the two other screen size options produces another outcome than when you use the default video size option. This one produces the "quarter of the screen video"

@barackenkumpel
Copy link

It is the same size the video has in minimized state rather than a quarter of the screen. I measured it.
Also see this screenshot:
pure-white-video_screenshot
The red area is usually not used when watching a video because of my screen proportions. When not noticing the red areas it's clearly not a quarter of the screen the video fills.

@Stypox
Copy link
Member

Stypox commented Jul 13, 2022

Could you try if, by any chance, #8170 fixes the issue? It probably does not, but let's check. This is the direct url to the APK built by the CI: https://github.com/TeamNewPipe/NewPipe/suites/7295032495/artifacts/294324129

Btw @privacyonly, there is no need to upload APKs to Mega, you can just zip them and then upload them here.

@yamatt
Copy link

yamatt commented Jul 13, 2022

@Stypox I've just tried it out and it looks like it's resolved the issue.

I went into full screen many times and it would always open on the whole screen whereas the current release is maybe 50% of the time.

@privacyonly
Copy link
Author

@Stypox, yes this fix the issue, thanks.

@Outlet2048
Copy link

Could you try if, by any chance, #8170 fixes the issue? It probably does not, but let's check. This is the direct url to the APK built by the CI: https://github.com/TeamNewPipe/NewPipe/suites/7295032495/artifacts/294324129

I'm getting a 404 file not found error

@privacyonly
Copy link
Author

@AlertSubject login, refresh, download again, it is a zip file.

@Outlet2048
Copy link

Outlet2048 commented Jul 13, 2022 •
edited
Loading

@AlertSubject login, refresh, download again, it is a zip file.

Link works fine on Desktop
Github mobile app not so much
thanks, will test the app

Edit:
APK works fine for me, issue no longer exists when using debug APK

@Stypox Stypox mentioned this issue Jul 13, 2022
Merged
12 tasks
@triallax triallax mentioned this issue Aug 5, 2022
Open
5 tasks
@AudricV AudricV unpinned this issue Aug 12, 2022
@AudricV AudricV mentioned this issue Aug 13, 2022
Closed
5 tasks
@wanderinglethe
Copy link

wanderinglethe commented Aug 24, 2022 •
edited
Loading

#8170 this is only merged into dev, so isn't merged into master yet and therefore not in 0.23.2, right?

(Having the same problems on S21FE, OneUI 4.1 with NewPipe version 0.23.2, except that the "sometimes" is more of an almost always)

@Stypox
Copy link
Member

Stypox commented Aug 24, 2022

isn't merged into master yet and therefore not in 0.23.2, right?

Yes

@AudricV AudricV mentioned this issue Aug 30, 2022
Closed
6 tasks
@navilg
Copy link

navilg commented Nov 22, 2022

Are we still getting this issue ? I don't see it anymore in my phone.

@Outlet2048
Copy link

Are we still getting this issue ? I don't see it anymore in my phone.

Resolved for me

@opusforlife2
Copy link
Collaborator

Hence, why the issue is closed.

@PJansky PJansky mentioned this issue Jul 20, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software help wanted Help is wanted in fixing this issue player Issues related to any player (main, popup and background)
Projects
None yet
Milestone
No milestone