Skip to content

Update Player.java #8559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

privacyonly
Copy link

Try fix #7262

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • delay togglefullscreen so it wont show a quarter of fullscreen

Before/After Screenshots/Screen Record

  • Before:
  • After:

Fixes the following issue(s)

Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@Stypox
Copy link
Member

Stypox commented Jul 13, 2022

Thank you for trying! If you say this really works, then I am ok with merging it. Can you provide more information about what happens now, whether it is actually fixed or is just a hack that only works sometimes, and other info that comes to your mind?

Btw, I think none of us team members is able to reproduce #7262, so we can't really test this or try to provide alternative solutions. The emulators work just fine.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AudricV
Copy link
Member

AudricV commented Jul 15, 2022

According to user reports, the issue seems to have been fixed with #8170. That's why I am closing this "try-test" PR.

Anyway, thank you @privacyonly for your researches and the time you spent on this issue :)

@AudricV AudricV closed this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fullscreen sometimes show a quarter of a screen [Android 12]
3 participants