Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seek on clicking timestamp links in comments #2207

Merged
merged 4 commits into from
Apr 3, 2019

Conversation

yausername
Copy link
Contributor

Fixes #1968 (review)

There are some problems with the popup player:

  1. start a video in popup mode by clicking on a timestep-link in a video description or comment
  2. Notice the video repeating the first miliseconds again and again until some more of the video stream is buffered.
  3. Let the video play for some seconds
  4. Pause the video. Notice the current playback position is reset back to the point from where we started in 1.

In some cases this problem is even bigger.

  1. start a video in popup mode by clicking on a timestep-link in a video description or comment
  2. start another video in popup mode by clicking on a timestep-link in a video description or comment
  3. let the first video finish or skip it (to skip it, click on the popup notification and then press the control to get to the next video
  4. You'll be in an endless loop of the first frames. The only way the interrupt the loop is pressing the pause button. after pressing play again, the video is played properly.

@yausername yausername mentioned this pull request Mar 13, 2019
1 task
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good and works way better now 👍

@TobiGr TobiGr merged commit 09eeaa9 into TeamNewPipe:dev Apr 3, 2019
@TobiGr
Copy link
Contributor

TobiGr commented Apr 3, 2019

Thanks, I forgot to merge 🤦‍♂️

This was referenced Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants