Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.16.2 #2312

Merged
merged 180 commits into from
May 31, 2019
Merged

Release v0.16.2 #2312

merged 180 commits into from
May 31, 2019

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Apr 28, 2019

We should release bug fixes from time to time... :)

newpipe_0.16.2_rc2_debug.apk.zip (by @TobiGr)

Please report crashes and bugs in #2314

Changelog

Improvements

Fixed

ToDo

  • Update Weblate translations

Klearchos-K and others added 30 commits December 24, 2018 20:11
Add dunction handleText() for #1951 issue
fix invalid channel url for commends
Fix AudioManager memory leak
added top padding for comments and related videos
Currently translated at 100.0% (443 of 443 strings)
#1 check if cancel was called in onPrepare
#2 if we currently don't have a Connection, don't show crash report dialogue to user
Fixed CheckForNewAppVersionTask being executed when it shouldn't
Currently translated at 100.0% (443 of 443 strings)
@TobiGr TobiGr mentioned this pull request Apr 30, 2019
1 task
@Brimont
Copy link

Brimont commented May 1, 2019

I have test this release, and it work Well! Thanks for your work :)

@TobiGr TobiGr force-pushed the release_v0.16.2 branch from 2ada722 to ff52fe4 Compare May 3, 2019 06:00
@uw0s
Copy link
Contributor

uw0s commented May 3, 2019

Correct me if I'm wrong but I think the Close button when a video ends doesn't work as intended. To elaborate:

  1. Enable "Minimize to popup player" on app switch
  2. Open up a video and when it ends press the Close button

The video will start over on the popup player. Is that how it's supposed to work?
Thanks for your work!

@TobiGr
Copy link
Contributor Author

TobiGr commented May 3, 2019

Nice catch. @nv95 do you have time to look at it?

jonaaa20 and others added 5 commits May 6, 2019 14:48
Currently translated at 98.6% (437 of 443 strings)
Currently translated at 99.5% (441 of 443 strings)
Currently translated at 100.0% (443 of 443 strings)
Currently translated at 100.0% (443 of 443 strings)
Currently translated at 100.0% (443 of 443 strings)
@TobiGr
Copy link
Contributor Author

TobiGr commented May 12, 2019

@Artuist Thanks for reporting. I tried to track this down, but unfortunately, this is wrong behaviour is not limited to the close button, but to all player exit actions when minimize to background/popup is enabled. I first tried to find any related code which has been touched during the work on this release. After debugging and searching for too long, it turned out that this bug existed in previous versions, too.

Whenever a video is left by either closing it or switching to a different player, the player to minimize to is opened. For example, set minimize to background, open a video and than switch to popup. Both players will be started.

Therefore, I wouldn't see this as a blocker for this release. nevertheless, we should open a ticket.

@theScrabi AFAICS only the weblate update is missing to get this release out to the people.

tolstovka and others added 4 commits May 13, 2019 10:53
Currently translated at 100.0% (443 of 443 strings)
Currently translated at 100.0% (443 of 443 strings)
@TobiGr
Copy link
Contributor Author

TobiGr commented May 14, 2019

Thanks to @Stypox, we can ship two more fixes with 0,16.2:

  • prevent streams from not loading
  • fix YouTube subscription import

Here is the new RC: newpipe_0.16.2_rc2_debug.apk.zip

Currently translated at 96.8% (429 of 443 strings)
Tobias Groza and others added 4 commits May 25, 2019 04:49
Currently translated at 100.0% (443 of 443 strings)
Currently translated at 99.8% (442 of 443 strings)
Remove strings which have been deleted from the English strings file during development, but were translated via Weblate, which failed to pull and push our upstream repo.
@theScrabi
Copy link
Member

theScrabi commented May 28, 2019

@theScrabi AFAICS only the weblate update is missing to get this release out to the people.

I see.

You can add https://hosted.weblate.org/git/newpipe/strings/ as a git repository, and just pull from the dev branch there. You will have a million of commits coming from there messing up your commit history. However rebasing is not possible as it takes forever.

@TobiGr did I forget to document this?

@Pentaphon
Copy link

Yes, please. It's been too long. We are almost at June.

@TobiGr
Copy link
Contributor Author

TobiGr commented May 31, 2019

@theScrabi No, I just didn't see it at first

@TobiGr TobiGr merged commit 1670751 into master May 31, 2019
@TobiGr TobiGr deleted the release_v0.16.2 branch May 31, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.