Add search for subscription picker in the feed group dialog #3373
Conversation
mauriciocolli
added
feature request
|
Oh damn! That's cool! Also, now that you are working on it again, what would you think about a checkbox to show only the subs that still arent in a group? I think it could be handy when you have a lot of subscritptions (>100). Any idea about it :) ? Oops, i didnt see that #3377, please consider it :) |
app/src/main/java/org/schabi/newpipe/database/subscription/SubscriptionDAO.kt
Show resolved
Hide resolved
mauriciocolli
force-pushed
the
feed-add-search-sub-list
branch
from
a91ee2d to
841f47e
Compare
app/src/main/java/org/schabi/newpipe/local/subscription/dialog/FeedGroupDialog.kt
Outdated
Show resolved
Hide resolved
|
I found an issue while testing on Android 7.0: while filtering items with a search query, when clicking on those items nothing happens (i.e. no tick appears), but they are correctly added to the selected ones. The checkbox appears as soon as the query changes. |
|
@mauriciocolli What's the status of this PR and #3404? I moved both PRs to the 0.20.0 milestone, because there were no code changes. I am happy to merge them for 0.19.5 as soon as the reviews were addressed. |
The adapter could not tell the items were the same because the subscription class was missing some methods (i.e. equals and hashcode), so a full rebind was being done.
mauriciocolli
force-pushed
the
feed-add-search-sub-list
branch
from
841f47e to
9f3b356
Compare
I think I forgot to update the test APK when I last pushed, already fixed. Completed, just needed a rebase. |
What is it?
Description of the changes in your PR
Let the user search for subscriptions in the feed group dialog.
Testing apk
feed-add-search-sub-list.apk.zip