Add filter to the feed group dialog to show only ungrouped subscriptions #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NO don't, i am using a channel related to multiple feeds. I have local news channels in multiple feeds like but i am not against a button to filter it live for other users like you but i need this way |
|
@denemier he is not changing the way the groups work. It's just a new option. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4 tasks
The adapter could not tell the items were the same because the subscription class was missing some methods (i.e. equals and hashcode), so a full rebind was being done.
mauriciocolli
force-pushed
the
feed-add-filter-sub-list
branch
from
80322a0 to
2e6e75c
Compare
mauriciocolli
added
feature request
wb9688
reviewed
Jun 27, 2020
app/src/main/java/org/schabi/newpipe/database/subscription/SubscriptionDAO.kt
Show resolved
Hide resolved
|
Could you rebase now that #3373 has been merged? |
TobiGr
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Add a way to let user hide subscriptions from the subscription picker that are already included in any other group .
Fixes the following issue(s)
Relies on the following changes
Testing apk
feed-add-filter-sub-list.apk.zip