Add download option to long-press menu #6563

gitryder · 2021-06-23T20:34:34Z

What is it?

Feature (user facing)

Description of the changes in your PR

Add option to download the video when long-pressing items.

Fixes the following issue(s)

Fixes Direct download option in long press menu in info items #2171

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

I read the contribution guidelines.

triallax

Thanks for the PR! Please also use the new method in VideoDetailFragment so as to reduce code duplication.

app/src/main/java/org/schabi/newpipe/util/NavigationHelper.java

triallax · 2021-06-23T20:56:23Z

app/src/main/java/org/schabi/newpipe/util/NavigationHelper.java

+
+        try {
+            // Get the sortedVideoStreams and selectedVideoStreamIndex using ListHelper
+            final ArrayList<VideoStream> sortedVideoStreams = new ArrayList<>(


The variable's type should be List<VideoStream>, as we do not care about the implementation:

Suggested change

final ArrayList<VideoStream> sortedVideoStreams = new ArrayList<>(

final List<VideoStream> sortedVideoStreams = new ArrayList<>(

Made the changes that you suggested. However, using the same code in VideoDetailFragment will break MainActivity

NewPipe/app/src/main/java/org/schabi/newpipe/MainActivity.java

Lines 619 to 621 in 484c852

if (fragment instanceof VideoDetailFragment) {

((VideoDetailFragment) fragment).openDownloadDialog();

}

nadiration · 2021-07-14T21:03:23Z

Than you i have been waiting for this for a long time

Redirion

lgtm, tested it, works. All good. Thank you

Stypox

Thank you! Have you tested that it works correctly in the feed fragment with fast mode enabled?

app/src/main/java/org/schabi/newpipe/util/StreamDialogEntry.java

Stypox · 2021-07-18T11:19:24Z

app/src/main/java/org/schabi/newpipe/fragments/list/BaseListFragment.java

@@ -371,6 +371,7 @@ protected void showStreamDialog(final StreamInfoItem item) {
            ));
        }
        entries.add(StreamDialogEntry.open_in_browser);
+        entries.add(StreamDialogEntry.download);


Have you checked if the download option can be added to other places where StreamDialogEntry is used?

On it. I'll check it out.

Not sure about what I'm supposed to do here. @Stypox please help me understand what I should check

I just made a similar change in #7160. You add your entry in BaseListFragment, but there are a bunch of other locations that have similar code (adding options to the long-press menu for stream items).

Do a search for add(StreamDialogEntry. and you should turn them all up.

You'll also want to test that it actually works in each other place, because some of those places may have different data available. In most cases besides BaseListFragment, the name of the fragment is a good indicator of where to find it in the app.

@gitryder Android Studio tells me that StreamDialogEntry is used in these places:

Stypox · 2021-08-01T09:25:28Z

@gitryder any update?

gitryder · 2021-08-01T18:05:21Z

@gitryder any update?

Still working on it. Gimme only some time more

Stypox · 2021-08-01T18:12:11Z

@gitryder ok, no problem :-)

gitryder · 2021-09-20T07:52:46Z

@gitryder Hey, are you there? It has been over a month. 😰

Extremely sorry, still working on it, I've not been able to do what @Stypox requested, gimme one day more

gitryder · 2021-09-20T18:56:13Z

I lost my local copy that had this branch on it. How do I push to this same PR now?

Stypox · 2021-09-20T19:49:10Z

Just clone your repo again and git checkout add-download-to-long-press-menu

litetex · 2022-03-26T16:18:54Z

No progress since ~6months.
Please reopen this PR once the problems are fixed or better: Create a new PR.

Hanankhan1983 · 2022-07-13T22:01:11Z

How do I download it pls tell really need it :(

Stypox · 2022-07-13T22:22:03Z

@Hanankhan1983 this was added in #8397 and will be present in the next release; you can download an APK built by our CI from here: https://github.com/TeamNewPipe/NewPipe/suites/7347347309/artifacts/297870978

Hanankhan1983 · 2022-07-13T23:13:29Z

@Hanankhan1983 this was added in #8397 and will be present in the next release; you can download an APK built by our CI from here: https://github.com/TeamNewPipe/NewPipe/suites/7347347309/artifacts/297870978

Thanks!

AudricV added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels Jun 23, 2021

gitryder added 3 commits June 23, 2021 13:53

Add dialog item to longpress menu

3715886

Add method to download video without starting player

9269f24

Finish implementation of the download item

4a0c903

gitryder force-pushed the add-download-to-longpress-menu branch from cc6f35f to 4a0c903 Compare June 23, 2021 20:54

triallax suggested changes Jun 23, 2021

View reviewed changes

gitryder added 6 commits June 23, 2021 14:06

Rename method

e827440

Remove redundant comment

a1eb47d

Change variable type to List

3a04d2c

Use renamed method

1032179

Remove space to fix checkstyle error

dff3357

Make use of extracted download-dialog method

024a03c

gitryder requested a review from triallax June 28, 2021 05:47

Redirion previously approved these changes Jul 15, 2021

View reviewed changes

triallax previously approved these changes Jul 15, 2021

View reviewed changes

Stypox requested changes Jul 18, 2021

View reviewed changes

SameenAhnaf mentioned this pull request Jul 25, 2021

Better playback bar and player interaction and other improvements #6753

Closed

3 tasks

This comment was marked as off-topic.

Sign in to view

gitryder dismissed stale reviews from triallax and Redirion via 52f8dce September 20, 2021 19:53

Show error if StreamInfo fetching fails

52f8dce

skyGtm mentioned this pull request Sep 29, 2021

Download button appears late #7106

Closed

4 tasks

SameenAhnaf mentioned this pull request Oct 9, 2021

Option to download the video from the long press menu #7214

Closed

3 tasks

SameenAhnaf mentioned this pull request Feb 27, 2022

Download videos without opening #7959

Closed

5 tasks

litetex added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Mar 15, 2022

litetex closed this Mar 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add download option to long-press menu #6563

Add download option to long-press menu #6563

gitryder commented Jun 23, 2021

triallax left a comment

triallax Jun 23, 2021

gitryder Jun 23, 2021

nadiration commented Jul 14, 2021

Redirion left a comment

Stypox left a comment

Stypox Jul 18, 2021

gitryder Jul 19, 2021

gitryder Sep 20, 2021

nschulzke Sep 28, 2021

Stypox Nov 13, 2021 •

edited

Loading

Stypox commented Aug 1, 2021

gitryder commented Aug 1, 2021

Stypox commented Aug 1, 2021

This comment was marked as off-topic.

gitryder commented Sep 20, 2021

gitryder commented Sep 20, 2021

Stypox commented Sep 20, 2021

litetex commented Mar 26, 2022 •

edited by triallax

Loading

Hanankhan1983 commented Jul 13, 2022

Stypox commented Jul 13, 2022

Hanankhan1983 commented Jul 13, 2022

	final ArrayList<VideoStream> sortedVideoStreams = new ArrayList<>(
	final List<VideoStream> sortedVideoStreams = new ArrayList<>(

	if (fragment instanceof VideoDetailFragment) {
	((VideoDetailFragment) fragment).openDownloadDialog();
	}

Add download option to long-press menu #6563

Add download option to long-press menu #6563

Conversation

gitryder commented Jun 23, 2021

What is it?

Description of the changes in your PR

Fixes the following issue(s)

APK testing

Due diligence

triallax left a comment

Choose a reason for hiding this comment

triallax Jun 23, 2021

Choose a reason for hiding this comment

gitryder Jun 23, 2021

Choose a reason for hiding this comment

nadiration commented Jul 14, 2021

Redirion left a comment

Choose a reason for hiding this comment

Stypox left a comment

Choose a reason for hiding this comment

Stypox Jul 18, 2021

Choose a reason for hiding this comment

gitryder Jul 19, 2021

Choose a reason for hiding this comment

gitryder Sep 20, 2021

Choose a reason for hiding this comment

nschulzke Sep 28, 2021

Choose a reason for hiding this comment

Stypox Nov 13, 2021 • edited Loading

Choose a reason for hiding this comment

Stypox commented Aug 1, 2021

gitryder commented Aug 1, 2021

Stypox commented Aug 1, 2021

This comment was marked as off-topic.

gitryder commented Sep 20, 2021

gitryder commented Sep 20, 2021

Stypox commented Sep 20, 2021

litetex commented Mar 26, 2022 • edited by triallax Loading

Hanankhan1983 commented Jul 13, 2022

Stypox commented Jul 13, 2022

Hanankhan1983 commented Jul 13, 2022

Stypox Nov 13, 2021 •

edited

Loading

litetex commented Mar 26, 2022 •

edited by triallax

Loading