Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better playback bar and player interaction and other improvements #6753

Closed
3 tasks done
ghost opened this issue Jul 24, 2021 · 10 comments
Closed
3 tasks done

Better playback bar and player interaction and other improvements #6753

ghost opened this issue Jul 24, 2021 · 10 comments
Labels
duplicate Issue or discussion is a duplicate of an existing issue or discussion template ignored The user didn't follow the template/instructions (or removed them)

Comments

@ghost
Copy link

ghost commented Jul 24, 2021

Checklist

Describe the feature you want

If let's say I start a music video then stop playing in the middle, then exit out of the app the player will remember where the player stopped and it will play from there if opened again. If I listen to music this is might not be desirable.

When tapping on a video, we cannot scroll the playback bar to scroll to the beginning, only until we start the stream. This is bit annoying since we have to click twice, wait the buffer to load, then scroll to the beginning, then wait again to play.

Solution:

Tap 1: When opening the player, a big play button appears but no scroll bar or other buttons. (1st image)

Tap 2 on the player: When clicking again other options and a playback bar appears thats navigatable. (2nd image)

I suggest the Tap 1 be skipped and lets go straight to the Tap 2 part. We could then set the resolution, the position, speed, without wasting time and data. No data needs to be downloaded, only when clicking on the play button.

[STREAM PREFETCHING RECOMMENDATION WAS HERE, MOVED TO NEW ISSUE #6759]

Or alternatively do #6380.

Is your feature request related to a problem? Please describe it

Additional context

1

2

How will you/everyone benefit from this feature?

More productive, faster and more logical implementation.

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Jul 25, 2021

When tapping on a video, we cannot scroll the playback bar to scroll to the beginning, only until we start the stream. This is bit annoying since we have to click twice, wait the buffer to load, then scroll to the beginning, then wait again to play.

If I didn't misunderstand the issue, there had already been an option available in the settings.
Go to 'Settings'>'History and Cache' and you will find the option.

Resume playback: Disable it to always start the playback over.
Positions in list: It only indicates the last playback position. But disabling or enabling it won't affect the previous settings.
IMG_20210725_084615

Also there could be an option in the settings that enables automatically prefetching the video (if there are currently none):

So if autoplay is enabled:

Video downloads, and autoplays

If autoplay disabled but "prebuffer" is enabled:

Video downloads, but no autoplay

If prefetching is disabled:

No download, only when tapping play, no autoplay

Please discuss about this in a separate issue. You have already checked the checkbox.

This issue contains only one feature request. I will open one issue for every feature I want to request.

@ghost
Copy link
Author

ghost commented Jul 25, 2021

@SameenAhnaf I will make a separate issue although it was sort of an alternative.

What I meant was that there are currently no option to start a video straight from the beginning while resume playback is enabled.

The one solution was to have a playback bar when opening a video so we don't have to start the stream to access the currently existing one. So I suggested we skip the big hollow play button start and go straight to the second UI. Then we could change the resolution and other settings as well as scroll to the beginning of the video without starting a stream. The starting of the video would be the same as starting it before.

I presented the alternative of implementing a menu option but expressed that implementing both would be better. I'll insert thenew issue number under the second option but I'll go and make it first.

I also suggested that let's have an option to prefetch the video while we did not started the stream. I'll make an issue for this as well.

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Jul 25, 2021

@IHateTheProgrammingClass So, you are asking for a menu which will ask for "Start over or resume?". Then, you may keep the discussion in #6380.

@ghost
Copy link
Author

ghost commented Jul 25, 2021

@SameenAhnaf I have already made a new issue. I'll close it.

@ghost
Copy link
Author

ghost commented Jul 25, 2021

Also that was only an alternative. The main focus is on the UI skip solution in this issue. That would be just a good addition.

@SameenAhnaf
Copy link
Collaborator

I'd personally say that your suggestions are not straight forward. I myself had to freeze for 2 minutes what you were asking for. #6380 is common in many other media players.

You may copy and paste your ideas in that issue.

Btw, won't #6563 suit your needs instead of prefetching videos? It's not that hard to understand if my connection is slow.

@ghost
Copy link
Author

ghost commented Jul 25, 2021

@SameenAhnaf I do my best to convert my thoughts into proper English. But I understand if something is confusing. In this case please point it out and I happily clarify.

#6380 is common in many other media players.

Sorry but I don't understand how other media players are related to NewPipe. Also I mentioned my duplicate issue in that one so it's all good.

Btw, won't #6563 suit your needs instead

If I understood correctly what this does is create a shortcut to download a video? I would like a setting that would enable the "prebuffering" / "prefetching" the stream of a video IF autoplay is disabled so when manually starting the video later, the video does not have to load. All this while being able to set it to only do this on WiFi for example. I don't know if we understood each other correctly but again please point out if you don't understand something or I misunderstood something.

@SameenAhnaf
Copy link
Collaborator

Sorry but I don't understand how other media players are related to NewPipe.

Other media players are NOT related to NewPipe. I was just talking about adding a usual behavior instead that most users are already familiar with.

I would like a setting that would enable the "prebuffering" / "prefetching" the stream of a video IF autoplay is disabled so when manually starting the video later, the video does not have to load.

I understand your use case now. Sorry for all the misunderstanding.

@triallax triallax added feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background) labels Oct 21, 2021
@SameenAhnaf
Copy link
Collaborator

@litetex Duplicate of #1928

@litetex
Copy link
Member

litetex commented Feb 15, 2022

Issue not understandable, Images are dead and duplicate of #1928

@litetex litetex closed this as completed Feb 15, 2022
@litetex litetex added the duplicate Issue or discussion is a duplicate of an existing issue or discussion label Feb 15, 2022
@SameenAhnaf SameenAhnaf added template ignored The user didn't follow the template/instructions (or removed them) and removed feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background) labels Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issue or discussion is a duplicate of an existing issue or discussion template ignored The user didn't follow the template/instructions (or removed them)
Projects
None yet
Development

No branches or pull requests

3 participants