Convert PlayerHolder to Singleton; cleanup in VideoDetailFragment; Player/MainPlayer do not call onDestroy() directly #6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ually instead use service.stopService() which inturn calls stopSelf() and triggers hopefully onDestroy() to be called. Eventually we have to make sure that all ServiceConnections are closed to successfully stop the service now! Cleanup within stopService() and not only onDestroy() So we make sure that all listeners can react to onServiceStopped() and close their ServiceConnections. Afterwards the android framework is ready to stop the Service.
evermind-zz
changed the title
AudricV
added
the
codequality
evermind-zz
force-pushed
the
various-fixes-for-upstream
branch
from
68ae360 to
dc4443a
Compare
Stypox
requested changes
Jul 5, 2021
app/src/main/java/org/schabi/newpipe/player/helper/PlayerHolder.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/player/helper/PlayerHolder.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
Outdated
Show resolved
Hide resolved
- code is easier to read - duplication of code reduced
…iceConnection leak - bugfix: have ServiceConnection created only once! - select the context within the PlayerHolder to start, stop, bind or unbind the service -> we have to make sure the Service is started AND stopped within the same context -> so let PlayerHolder be the one to select the context - remove removeListener() and replace the call with setListener(null) - Compatibility: use ContextCompat.startForegroundService instead of startService()
evermind-zz
force-pushed
the
various-fixes-for-upstream
branch
from
dc4443a to
48c2c15
Compare
|
I've merged the changes and updated the pull request |
Stypox
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence