Release 0.21.9 #6841

Stypox · 2021-08-04T10:02:13Z

APK for testing

From GitHub Actions: NewPipe_v0.21.9_RC2.zip

Corresponding pull request: #6840

TODO

Push changelog to Weblate (@B0pol could you do this?)
Merge Fix channel item span count for SubscriptionFragment #6814
Merge Play queue theme #6847
Pull from Weblate just before merging
Update extractor version

App changelog

SameenAhnaf · 2021-08-04T10:34:20Z

Is this intended? The seek bar and buffering icon are red for every single service.

Screenshot

SameenAhnaf · 2021-08-04T14:00:21Z

@Movisivi No, this is a test apk. It's not a mainstream release. It will NOT install over your main app rather as a separate app.

It's released to make sure that users don't encounter bugs. A stable apk will be released later once the bugs (if bugs do exist) are fixed.

Stypox · 2021-08-04T15:30:06Z

The seek bar and buffering icon are red for every single service.

The color depends on the currently chosen service, not on the video currently being played. Then again, maybe you actually had SoundCloud selected. Let me check.

Btw, when you send screenshots, could you please make them properly sized? Use <img src="INSERT_LINK_HERE" height="300px"/>. Hint: you can add this as a saved github reply so that you don't have to learn it by heart. I've edited your comment

Stypox · 2021-08-04T15:54:51Z

@SameenAhnaf does #6847 solve it?

flopezre · 2021-08-04T23:49:41Z

Error to download a video:

-------------------------------------
java.io.EOFException: parser go beyond limits of the box. type=���� offset=26990656 size=0 position=26990664
	at org.schabi.newpipe.streams.Mp4DashReader.ensure(Mp4DashReader.java:311)
	at org.schabi.newpipe.streams.Mp4DashReader.getNextChunk(Mp4DashReader.java:182)
	at org.schabi.newpipe.streams.Mp4FromDashWriter.getNextSample(Mp4FromDashWriter.java:407)
	at org.schabi.newpipe.streams.Mp4FromDashWriter.getNextSample(Mp4FromDashWriter.java:416)
	at org.schabi.newpipe.streams.Mp4FromDashWriter.build(Mp4FromDashWriter.java:333)
	at us.shandian.giga.postprocessing.Mp4FromDashMuxer.process(Mp4FromDashMuxer.java:22)
	at us.shandian.giga.postprocessing.Postprocessing.run(Postprocessing.java:174)
	at us.shandian.giga.get.DownloadMission.doPostprocessing(DownloadMission.java:703)
	at us.shandian.giga.get.DownloadMission.lambda$J0GR1urTFneOp2O30GpOM3TNG0I(Unknown Source:0)
	at us.shandian.giga.get.-$$Lambda$DownloadMission$J0GR1urTFneOp2O30GpOM3TNG0I.run(Unknown Source:2)
	at java.lang.Thread.run(Thread.java:923)
-------------------------------------

skyGtm · 2021-08-05T00:40:41Z

The colors are not changed according to selected service for these sections :

Downloads
Settings
About

Is this intended behaviour?

SameenAhnaf · 2021-08-05T03:02:45Z

@skyGtm Technically, these three sections behave the same for all services at least for now. So, I guess, changing these sections' colours might be unnecessary or even misleading as the differenciation is of no use.

Stypox · 2021-08-05T08:40:36Z

@flopezre could you provide more info? Android version, the video you were downloading, resolution, audio/video, SAF or non-SAF, ...

enessgokalp · 2021-08-05T13:39:30Z

Thumbnail is blurry, but when you enter the video, it is of good quality

Stypox · 2021-08-05T19:44:05Z

Thumbnail is blurry, but when you enter the video, it is of good quality

Has that something to do with youtubei @TiA4f8R

flopezre · 2021-08-05T20:48:10Z

@flopezre could you provide more info? Android version, the video you were downloading, resolution, audio/video, SAF or non-SAF, ...

Android version: 11
Video: https://youtu.be/V25KzeuREj4 (Russian ASMR)
Resolution: 1080p
Audio/Video: Yes (?)
SAF: Yes (?)

Stypox · 2021-08-06T07:16:00Z

@flopezre I could download it just fine. But it's 2.19GB, so I guess that's causing the issue. Are you sure you have enough free space on disk? And are you sure your filesystem supports files that big? Anyway, I don't think that crash is related to the new release, as we didn't change anything regarding the downloader. @kapodamy could you check that stacktrace?

flopezre · 2021-08-06T13:42:33Z

@Stypox ok, i try to reinstall.

Thanks

Update: now works perfect 👌👌

bookkojot · 2021-08-06T18:04:25Z

Age-restricted videos fixed?

AudricV · 2021-08-07T17:34:42Z

Thumbnail is blurry, but when you enter the video, it is of good quality

Has that something to do with youtubei @TiA4f8R

@Stypox The issue is present since a while ago, (I can reproduce it on the current version) and is an extractor issue: see https://github.com/TeamNewPipe/NewPipeExtractor/blob/dev/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemExtractor.java#L238-L240

Here is the commit which added this code: TeamNewPipe/NewPipeExtractor@b88188d#diff-2d29793b2428b5ed716b13435abfad6b7af77d412b65dfcb513998610f69e444

This commit may be however not responsible of the current issue, lower thumbnails may have been added by YouTube after the code was implemented in the extractor.

opusforlife2 · 2021-08-08T12:18:17Z

Age-restricted videos fixed?

@bookkojot Some, not all.

bew · 2021-08-09T19:18:22Z

I'm using the pre-release app for 0.21.9 (with SAF enabled) and I experience #6667, which was supposedly fixed and released in 0.21.7...
(was about to open a new issue for this)

To start the download I have to open the app, go in the download queue and start the download manually.

demonstration in video

2021-08-09-212919245.mp4

NOTE: For some reason (but not often, doesn't always reproduce) the download isn't always queued (but that might be a separate bug).

Stypox · 2021-08-09T21:22:10Z

@bew Mmmh no, #6667 is unrelated. At least your app doesn't crash. I don't know if that happened in previous versions, too, or if this is a regression. Anyway, I took a look at the code and found two things that could queue the download without starting it:

you have the "Limit download queue" setting activated and you have already one download running, but that doesn't seem the case by looking at your video
the network might be unavailable. By looking at the video, you seem not to have a stable connection, so maybe this could be the case.

Anyway, could you send a screenshot of your download settings screen? thank you ;-)

bew · 2021-08-09T21:54:44Z

Anyway, could you send a screenshot of your download settings screen? thank you ;-)

Sure!
Actually I didn't configure the pre-release app (except the download folder iirc)

opusforlife2 · 2021-08-10T07:22:32Z

The colors are not changed according to selected service for these sections :

Maybe we should have a neutral colour for non-service-related sections?

SameenAhnaf · 2021-08-10T07:27:02Z

@opusforlife2 Shouldn't Newpipe app icon itself should be other than red in that case? After all, app icon is one of the core neutral parts.

opusforlife2 · 2021-08-10T09:23:34Z

@SameenAhnaf That then affects the familiarity/discoverability factor, which needs a far more detailed discussion as it may hurt the app instead of helping.

SameenAhnaf · 2021-08-10T09:56:35Z

@opusforlife2 Personally, I think that finding a neutral color is too general at this moment. The related PRs #6771 and #6456 actually were supposed to apply theme to each service.

Even if we don't apply neutral color on app icon right now, surely a new issue will be generated. So, it's best to have a discussion on this later.

TobiGr · 2021-08-10T11:29:43Z

NewPipe_v0.21.9_RC2.zip
Changes since RC1:

Fixed PlayQueue theme
Fixed grid of channel items
Updated translations
[YouTube] Updated supported country list
[YouTube] Faster iframe-API based player extraction
Updated the extractor's Gradle version to 7.1.1

Disqu3-mirOir-qt · 2021-08-11T15:25:38Z

get error when try , import database

Exception

User Action: ui error
Request: ACRA report
Content Country: GB
Content Language: en-GB
App Language: en_GB
Service: none
Version: 0.21.9
OS: Linux Android 8.0.0 - 26

Crash log

android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.OPEN_DOCUMENT cat=[android.intent.category.OPENABLE] typ=*/* flg=0x43 (has extras) }
	at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:1981)
	at android.app.Instrumentation.execStartActivity(Instrumentation.java:1636)
	at android.app.Activity.startActivityForResult(Activity.java:4762)
	at androidx.activity.ComponentActivity.startActivityForResult(ComponentActivity.java:597)
	at androidx.core.app.ActivityCompat.startActivityForResult(ActivityCompat.java:237)
	at androidx.activity.ComponentActivity$2.onLaunch(ComponentActivity.java:210)
	at androidx.activity.result.ActivityResultRegistry$2.launch(ActivityResultRegistry.java:167)
	at androidx.fragment.app.Fragment$9.launch(Fragment.java:3510)
	at androidx.activity.result.ActivityResultLauncher.launch(ActivityResultLauncher.java:47)
	at org.schabi.newpipe.settings.ContentSettingsFragment.lambda$onCreatePreferences$0$ContentSettingsFragment(ContentSettingsFragment.java:79)
	at org.schabi.newpipe.settings.-$$Lambda$ContentSettingsFragment$IJ0-sY_2nFZ8j0D13C6AQ28cAn0.onPreferenceClick(Unknown Source:2)
	at androidx.preference.Preference.performClick(Preference.java:1184)
	at androidx.preference.Preference.performClick(Preference.java:1166)
	at androidx.preference.Preference$1.onClick(Preference.java:181)
	at android.view.View.performClick(View.java:6291)
	at android.view.View$PerformClick.run(View.java:24931)
	at android.os.Handler.handleCallback(Handler.java:808)
	at android.os.Handler.dispatchMessage(Handler.java:101)
	at android.os.Looper.loop(Looper.java:166)
	at android.app.ActivityThread.main(ActivityThread.java:7529)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:245)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:921)

nadiration · 2021-08-13T04:25:31Z

@Stypox Add #6848?

Stypox · 2021-08-13T09:56:37Z

get error when try , import database

@Disqu3-mirOir-qt Your OS does not seem to support SAF, even though it should since it's Android 8. Just disable it in "Settings -> Download -> Use Storage Access Framework". This issue is anyway unrelated to this release.

@Stypox Add #6848?

@nadiration next release, this release is already on its way

Thewisem · 2021-08-14T19:36:39Z

This is a problem that I found in this update.
Steps:

Open Newpipe
Watch a video for some time
Open in popup mode in middle of video
Watch for some more time
Then go back to original mode
See player change
The video goes to the timestamp before the popup mode instead of continuing

SameenAhnaf · 2021-08-14T19:54:26Z

@Thewisem This is an old issue and not exclusive to this release. See: #6472.

Thewisem · 2021-08-14T20:23:19Z

Oops Sorry then

SameenAhnaf · 2021-08-15T19:25:43Z

I found a new bug.

Turn system rotation off.
Open any landscape video on full screen and swipe down to mini player. The app is set to landscape as expected
Open another video.
Swipe down before the buffering ends.
Notification player stays stuck and needs to be swiped away.

Stypox · 2021-08-16T12:02:48Z

I found a new bug.

I can't reproduce

SameenAhnaf · 2021-08-21T09:28:04Z

@Stypox The bug seems to persist for other media player apps on my device. So, pardon me if I did something wrong.

However, 'Mark as Watched' does nothing if watch history is disabled. Shouldn't it be hidden if history is disabled? Or, maybe, support for temporary watch history (until closing the app) could be added.

TobiGr · 2021-08-22T17:48:31Z

However, 'Mark as Watched' does nothing if watch history is disabled

Will be fixed by #6956

mshjz · 2021-08-24T06:57:48Z

goyalyashpal · 2021-10-18T04:24:33Z

Btw, when you send screenshots, could you please make them properly sized? Use <img src="INSERT_LINK_HERE" height="300px"/>
#6841 (comment) by @Stypox

hiii,

i know this is a bit OT, but thanks a lottttt for sharing this.
Up untill now, i painstakingly scaled images down in image editing/manipulating softwares - that used to take so much time and frustrate me so much.
But not any more 😃 for majority of time
any other way to accomplish it? for example when using reference links?

Hint: you can add this as a saved github reply

how?? 🤔 it showed no such options in that comments 3-dot menu.

had lost this comment, refound by: 🔍 repo:teamnewpipe/newpipe in:comments img src

opusforlife2 · 2021-10-22T23:22:19Z

@yashpalgoyal1304 Last option on the right.

Stypox mentioned this issue Aug 4, 2021

Release 0.21.9 #6840

Merged

Stypox pinned this issue Aug 4, 2021

Stypox mentioned this issue Aug 4, 2021

Crashing when downloading because of SAF #6687

Closed

4 tasks

triallax mentioned this issue Aug 4, 2021

Tablet aligning information #6832

Closed

4 tasks

SameenAhnaf mentioned this issue Aug 4, 2021

Play queue theme #6847

Merged

5 tasks

SameenAhnaf mentioned this issue Aug 8, 2021

Error when downloading #6875

Closed

This comment has been minimized.

Sign in to view

SameenAhnaf mentioned this issue Aug 10, 2021

dont show comments #6886

Closed

This comment has been minimized.

Sign in to view

triallax mentioned this issue Aug 11, 2021

Crash occurs when attempting to download a video #6899

Closed

4 tasks

triallax mentioned this issue Aug 19, 2021

Version 0.21.7 Broke Subscriptions Page Condensed Grid Layout #6802

Closed

4 tasks

SameenAhnaf mentioned this issue Aug 21, 2021

Intermittent, constant buffering #6949

Closed

4 tasks

TobiGr closed this as completed Aug 24, 2021

TobiGr unpinned this issue Aug 24, 2021

litetex mentioned this issue Sep 3, 2021

Change "No comments" message on videos where creator disabled comments #5380

Closed

3 tasks

goyalyashpal mentioned this issue Jan 2, 2022

YouTube "seasons" (or series) are not discoverable in search results #5793

Closed

4 tasks

Release 0.21.9 #6841

Release 0.21.9 #6841

Comments

Stypox commented Aug 4, 2021 • edited by TobiGr Loading

APK for testing

TODO

App changelog

New

Improved

Fixed

Development

SameenAhnaf commented Aug 4, 2021 • edited Loading

SameenAhnaf commented Aug 4, 2021

Stypox commented Aug 4, 2021 • edited Loading

Stypox commented Aug 4, 2021

flopezre commented Aug 4, 2021 • edited Loading

skyGtm commented Aug 5, 2021

SameenAhnaf commented Aug 5, 2021

Stypox commented Aug 5, 2021

enessgokalp commented Aug 5, 2021 • edited by Stypox Loading

Stypox commented Aug 5, 2021

flopezre commented Aug 5, 2021 • edited by Stypox Loading

Stypox commented Aug 6, 2021

flopezre commented Aug 6, 2021 • edited Loading

bookkojot commented Aug 6, 2021

AudricV commented Aug 7, 2021

opusforlife2 commented Aug 8, 2021

This comment has been minimized.

bew commented Aug 9, 2021 • edited Loading

Stypox commented Aug 9, 2021 • edited Loading

bew commented Aug 9, 2021 • edited Loading

opusforlife2 commented Aug 10, 2021

SameenAhnaf commented Aug 10, 2021 • edited Loading

opusforlife2 commented Aug 10, 2021

SameenAhnaf commented Aug 10, 2021

TobiGr commented Aug 10, 2021

This comment has been minimized.

Disqu3-mirOir-qt commented Aug 11, 2021 • edited Loading

Exception

nadiration commented Aug 13, 2021

Stypox commented Aug 13, 2021 • edited Loading

Thewisem commented Aug 14, 2021

SameenAhnaf commented Aug 14, 2021

Thewisem commented Aug 14, 2021

SameenAhnaf commented Aug 15, 2021

Stypox commented Aug 16, 2021

SameenAhnaf commented Aug 21, 2021

TobiGr commented Aug 22, 2021

mshjz commented Aug 24, 2021

goyalyashpal commented Oct 18, 2021 • edited Loading

opusforlife2 commented Oct 22, 2021

Stypox commented Aug 4, 2021 •

edited by TobiGr

Loading

SameenAhnaf commented Aug 4, 2021 •

edited

Loading

Stypox commented Aug 4, 2021 •

edited

Loading

flopezre commented Aug 4, 2021 •

edited

Loading

enessgokalp commented Aug 5, 2021 •

edited by Stypox

Loading

flopezre commented Aug 5, 2021 •

edited by Stypox

Loading

flopezre commented Aug 6, 2021 •

edited

Loading

bew commented Aug 9, 2021 •

edited

Loading

Stypox commented Aug 9, 2021 •

edited

Loading

bew commented Aug 9, 2021 •

edited

Loading

SameenAhnaf commented Aug 10, 2021 •

edited

Loading

Disqu3-mirOir-qt commented Aug 11, 2021 •

edited

Loading

Stypox commented Aug 13, 2021 •

edited

Loading

goyalyashpal commented Oct 18, 2021 •

edited

Loading