Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show "mark as watched" when watch history is enabled #6956

Merged
merged 1 commit into from
Aug 22, 2021

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Aug 22, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Only display the "mark as watched" item in the feed context menu when the watch history is enabled.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@TobiGr TobiGr added bug Issue is related to a bug feed Issue is related to the feed labels Aug 22, 2021
@TobiGr TobiGr mentioned this pull request Aug 22, 2021
5 tasks
@TobiGr TobiGr marked this pull request as draft August 22, 2021 17:49
@TobiGr TobiGr force-pushed the fix/mark-as-watched branch from c6f1753 to 360cb03 Compare August 22, 2021 17:57
@TobiGr TobiGr marked this pull request as ready for review August 22, 2021 17:57
@TobiGr TobiGr force-pushed the fix/mark-as-watched branch from 360cb03 to d980f3b Compare August 22, 2021 18:23
@SameenAhnaf
Copy link
Collaborator

Thanks for the PR! Not sure if it's worth noting here. But there's a related bug.

'Show/Hide played items' icon works neither for now. Maybe, 'Mark as Watched' should work as 'Temporary watch history' instead if 'Watch history' is disabled.

@TobiGr
Copy link
Contributor Author

TobiGr commented Aug 22, 2021

'Show/Hide played items' icon works neither for now.

@SameenAhnaf Please tell us what exactly does not work and the used history settings and stream states (not watched, stream position somewhere in the middle, watched completely). I cannot reproduce that.

@SameenAhnaf
Copy link
Collaborator

Sorry if I was not clear. I'm talking about this button. This button works neither when 'Watch history' is disabled. So, it should be hidden as well.

Should I open a separate issue?

IMG_20210823_012640

@TobiGr
Copy link
Contributor Author

TobiGr commented Aug 22, 2021

It works for me when the history is disabled. One can have watched items in the history when the history is paused.
Note that when disabling the watch history it is not cleared. We need to make this more obvious, e.g. by showing a toast in the settings

@TobiGr TobiGr merged commit 8715e7d into release_0.21.9 Aug 22, 2021
@TobiGr TobiGr deleted the fix/mark-as-watched branch August 22, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug feed Issue is related to the feed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants