Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some untranslatable string improvements #7317

Merged
merged 3 commits into from
Jan 21, 2022
Merged

Some untranslatable string improvements #7317

merged 3 commits into from
Jan 21, 2022

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Move untranslatable strings to a donottranslate file (the most hip file for strings too cool for multilingualism)
  • Update two of the links
  • Remove redundant XML attributes in settings_keys (makes them more readable IMO)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

APK probably not needed though.

Due diligence

@AudricV AudricV added the codequality Improvements to the codebase to improve the code quality label Oct 31, 2021
@litetex litetex self-requested a review November 1, 2021 22:06
litetex
litetex previously approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@litetex litetex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested the apk: Works as expected.

Would be great if someone who manages translation could take a look at this.

@litetex
Copy link
Member

litetex commented Nov 2, 2021

This PR will have conflicts when we merge #2335

@TacoTheDank
Copy link
Member Author

It's fine. I can rebase :)

Stypox
Stypox previously approved these changes Nov 13, 2021
View reviewed changes
@Stypox
Copy link
Member

Stypox commented Nov 13, 2021

I just saw there are some untranslatable strings in the util/Constants.kt file, too. Maybe you could take them out of that file and move them to settings_keys.xml?

@litetex
Copy link
Member

litetex commented Nov 14, 2021 •
edited
Loading

2 requests from my side:

  1. Please wait with merging until New streams notifications #2335 is done as it introduces new untranslatable stuff. It's now nearly finished and will get merged soon (hopefully).
  2. This PR needs to be rebased (but better do it after 1. is done).

@TacoTheDank TacoTheDank dismissed stale reviews from Stypox and litetex via 677ee6a December 4, 2021 23:59
@TacoTheDank
Copy link
Member Author

I will fix the error later.

@litetex
Copy link
Member

litetex commented Dec 29, 2021 •
edited
Loading

  1. Please wait with merging until New streams notifications #2335 is done as it introduces new untranslatable stuff. It's now nearly finished and will get merged soon (hopefully).

Note: I think we should no longer let this PR wait for #2335 because there is currently little progress.

@TacoTheDank
Copy link
Member Author

TacoTheDank commented Jan 8, 2022 •
edited
Loading

Took way too long lol but fixed👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

litetex
litetex reviewed Jan 8, 2022
View reviewed changes
Copy link
Member

@litetex litetex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

litetex failed to click on Approved

litetex
litetex approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took way too long lol but fixed👍

Better late than never 😄

Anyway LGTM, did a quick test, seems to work as expected.

@litetex litetex merged commit 2d0da2c into TeamNewPipe:dev Jan 21, 2022
@TacoTheDank TacoTheDank deleted the ignoreStrings branch January 21, 2022 21:07
@Stypox Stypox mentioned this pull request Jan 24, 2022
Merged
1 task
This was referenced Feb 11, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litetex litetex litetex approved these changes

@Stypox Stypox Stypox left review comments

Assignees
No one assigned
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TacoTheDank @litetex @Stypox @AudricV