-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.22.0 #7858
Merged
Merged
Release 0.22.0 #7858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit calls getStreamInfo causing a full network fetch of stream info (I believe only if required) when adding a stream item to the queue. This should prevent UI issues of missing metadata when queueing videos that have been fast-loaded and are missing metadata. Fixes #7035
Co-authored-by: Stypox <stypox@pm.me>
Co-authored-by: Stypox <stypox@pm.me>
Activity, snackbar and notification
The wrong @decorator was put in the wrong place to mark the throwable fieldd as transient, now this is fixed and the exception is not serialized. So if a non-serializable throwable is passed, that's not an issue, since it's not going to be serialized. The need for EnsureExceptionSerializable is also gone.
since the notification is silent, also show a toast, otherwise the user is confused
Updated/Fixed "Get it on F-Droid"
Disable media tunneling on Philips QM16XE
Co-authored-by: Stypox <stypox@pm.me>
Increase playlist stuck target duration coefficient and catch BehindLiveWindowExceptions properly
Co-authored-by: Mohammed Anas <triallax@tutanota.com>
Merge ``master`` branch back into ``dev``
Co-authored-by: Mohammed Anas <triallax@tutanota.com>
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Fix crash when long-pressing stream while player is starting
Add some stuff to `paths-ignore`
* Add changelog for NewPipe 0.22.0 (983) Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com> Co-authored-by: Mohammed Anas <triallax@tutanota.com>
…yer with content thumbnail The workaround set before was not applied when switching to main player with content thumbnail from popup or background player. This commit fixes this by applying the workaround when switching to main player with content thumbnail from popup or background player.
…-thumbnail Set workaround for playback position reset when switching to main player with content thumbnail
Co-authored-by: Mohammed Anas <triallax@tutanota.com>
Use the correct app language when searching in the settings
d4b8822
to
db44c5d
Compare
* Switched to GitHub issue forms See also * https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms * https://github.blog/changelog/2021-06-23-issues-forms-beta-for-public-repositories/ * Switched expected and actual behavior * Improved/Reworked issue template Credits to @TheAssassin * CI: Ignore changes to issue-templates * Improved/Reworked issue template Credits to @opusforlife2 and @mhmdanas * Further improved the issue templates * Next round of review Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Currently translated at 100.0% (64 of 64 strings) Translated using Weblate (Chinese (Traditional, Hong Kong)) Currently translated at 6.2% (4 of 64 strings) Translated using Weblate (Malay) Currently translated at 60.0% (368 of 613 strings) Translated using Weblate (Estonian) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Finnish) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Arabic) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Arabic) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Chinese (Traditional, Hong Kong)) Currently translated at 63.9% (392 of 613 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Dutch) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Dutch) Currently translated at 64.0% (41 of 64 strings) Translated using Weblate (Hebrew) Currently translated at 53.1% (34 of 64 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Polish) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Greek) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Dutch) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (German) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Polish) Currently translated at 54.6% (35 of 64 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (64 of 64 strings) Translated using Weblate (Norwegian Bokmål) Currently translated at 95.2% (584 of 613 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Slovak) Currently translated at 98.0% (601 of 613 strings) Translated using Weblate (Hungarian) Currently translated at 99.5% (610 of 613 strings) Translated using Weblate (English) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (63 of 63 strings) Translated using Weblate (Dutch) Currently translated at 46.0% (29 of 63 strings) Translated using Weblate (Hebrew) Currently translated at 52.3% (33 of 63 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (63 of 63 strings) Translated using Weblate (Interlingua) Currently translated at 35.0% (215 of 613 strings) Translated using Weblate (Danish) Currently translated at 49.1% (301 of 613 strings) Translated using Weblate (Norwegian Bokmål) Currently translated at 94.2% (578 of 613 strings) Translated using Weblate (Estonian) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Finnish) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Arabic) Currently translated at 99.6% (611 of 613 strings) Translated using Weblate (Dutch) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Dutch) Currently translated at 28.5% (18 of 63 strings) Translated using Weblate (Dutch) Currently translated at 28.5% (18 of 63 strings) Translated using Weblate (Swedish) Currently translated at 48.3% (30 of 62 strings) Translated using Weblate (French) Currently translated at 66.1% (41 of 62 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (62 of 62 strings) Translated using Weblate (Estonian) Currently translated at 99.8% (612 of 613 strings) Translated using Weblate (Catalan) Currently translated at 99.1% (608 of 613 strings) Translated using Weblate (Tamil) Currently translated at 55.4% (340 of 613 strings) Translated using Weblate (Finnish) Currently translated at 99.0% (607 of 613 strings) Translated using Weblate (Swedish) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Armenian) Currently translated at 19.0% (117 of 613 strings) Translated using Weblate (Chinese (Traditional)) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Persian) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Turkish) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Indonesian) Currently translated at 99.8% (612 of 613 strings) Translated using Weblate (Japanese) Currently translated at 99.8% (612 of 613 strings) Translated using Weblate (French) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (English) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Sardinian) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Arabic) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Kurdish (Central)) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Catalan) Currently translated at 99.3% (609 of 613 strings) Translated using Weblate (Lithuanian) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Hebrew) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Italian) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Dutch) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (French) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (German) Currently translated at 100.0% (613 of 613 strings) Added translation using Weblate (German (Low)) Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Polish) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Greek) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Russian) Currently translated at 100.0% (613 of 613 strings) Translated using Weblate (Malay) Currently translated at 4.8% (3 of 62 strings) Translated using Weblate (Chinese (Traditional, Hong Kong)) Currently translated at 4.8% (3 of 62 strings) Translated using Weblate (Galician) Currently translated at 94.9% (581 of 612 strings) Translated using Weblate (Malay) Currently translated at 60.1% (368 of 612 strings) Translated using Weblate (Malay) Currently translated at 60.1% (368 of 612 strings) Translated using Weblate (Tamil) Currently translated at 49.8% (305 of 612 strings) Translated using Weblate (Finnish) Currently translated at 97.2% (595 of 612 strings) Translated using Weblate (Arabic) Currently translated at 100.0% (612 of 612 strings) Translated using Weblate (Chinese (Traditional, Hong Kong)) Currently translated at 57.1% (350 of 612 strings) Translated using Weblate (French) Currently translated at 99.6% (610 of 612 strings) Translated using Weblate (English (United Kingdom)) Currently translated at 7.6% (47 of 612 strings) Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (62 of 62 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (62 of 62 strings) Translated using Weblate (Tamil) Currently translated at 44.6% (273 of 612 strings) Translated using Weblate (Arabic) Currently translated at 99.8% (611 of 612 strings) Co-authored-by: A <ville.mourujarvi@hostedweblate.mail.kapsi.fi> Co-authored-by: Agnieszka C <aga_04@o2.pl> Co-authored-by: Ajeje Brazorf <lmelonimamo@yahoo.it> Co-authored-by: Albert Vila <vilacalvo.albert@gmail.com> Co-authored-by: Alex25820 <alexs25820@gmail.com> Co-authored-by: Alfonso Scarpino <alfonso.scarpino@gmail.com> Co-authored-by: Allan Nordhøy <epost@anotheragency.no> Co-authored-by: Danial Behzadi <dani.behzi@ubuntu.com> Co-authored-by: Davit Mayilyan <davit.mayilyan@protonmail.ch> Co-authored-by: Denys Nykula <nykula@ukr.net> Co-authored-by: Eric <alchemillatruth@purelymail.com> Co-authored-by: GnuPGを使うべきだ <dieeeazpnnqbpddh@cock.email> Co-authored-by: GobinathAL <gobinathal8@gmail.com> Co-authored-by: Guillem <guillemglez@gmail.com> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Ihor Hordiichuk <igor_ck@outlook.com> Co-authored-by: JY3 <GeeyunJY3@gmail.com> Co-authored-by: Jeff Huang <s8321414@gmail.com> Co-authored-by: John Smith <a@shatin.ml> Co-authored-by: Karl Tammik <karltammik@protonmail.com> Co-authored-by: Lim Jia Ming <jiaminglimjm@protonmail.com> Co-authored-by: Linerly <linerly@protonmail.com> Co-authored-by: Marian Hanzel <marulinko@gmail.com> Co-authored-by: Mark <theMurk@protonmail.com> Co-authored-by: Mohammed Anas <6daf084a-8eaf-40fb-86c7-8500077c3b69@anonaddy.me> Co-authored-by: Mohammed Anas <triallax@tutanota.com> Co-authored-by: MohammedSR Vevo <mohammednajmidin@gmail.com> Co-authored-by: My <quentin.lalle@gmail.com> Co-authored-by: Ray <ray.cfu@protonmail.com> Co-authored-by: Rex_sa <rex.sa@pm.me> Co-authored-by: Ricardo <contatorms7@tutamail.com> Co-authored-by: S3aBreeze <paperwork@evilcorp.ltd> Co-authored-by: SamTada <SamLbttyw@protonmail.com> Co-authored-by: Software In Interlingua <softinterlingua@gmail.com> Co-authored-by: THANOS SIOURDAKIS <siourdakisthanos@gmail.com> Co-authored-by: Thomas Frarke <goetzknecht23@gmail.com> Co-authored-by: TobiGr <tobigr@mail.de> Co-authored-by: Vasilis K <skyhirules@gmail.com> Co-authored-by: VfBFan <drop0815@posteo.de> Co-authored-by: Ville Rantanen <v.r@iki.fi> Co-authored-by: WB <web0nst@tuta.io> Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com> Co-authored-by: chr56 <chr0056@gmail.com> Co-authored-by: gymka <gymka@archlinux.lt> Co-authored-by: jojo <welwhazosky@gmail.com> Co-authored-by: mm4c <oldblue@vivaldi.net> Co-authored-by: nzgha <nzgha.hw@runbox.com> Co-authored-by: ssantos <ssantos@web.de> Co-authored-by: translator <kvb@tuta.io> Co-authored-by: xainsworth <202120614015@ogr.balikesir.edu.tr> Co-authored-by: Ács Zoltán <acszoltan111@gmail.com> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fr/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/he/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ms/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/nl/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pl/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sv/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/uk/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/zh_Hans/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/zh_Hant_HK/ Translation: NewPipe/Metadata
db44c5d
to
54f0b3d
Compare
This happened in fullscreen player: while play-pause, brightness, volume, ... buttons were correctly centered in the app UI, the fast seek overlay was centered in the system UI, causing a mismatch between the two that looked ugly
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APKs for testing
NewPipe_v0.22.0_RC4.zip
REPORT NEW ISSUES IN #7857, NOT IN THIS PR!
Known Issues / ToDo:
Changelog
App
New
35 - New Fast Forward/Rewind behavior #4833
36 - Searchable Preferences / Settings #7586
13 - Highlight pinned comments as such #7577
2 - Add FSFE-Tube PeerTube instance #7481
Improved
5 - Unify error reporting and add error notification #7482
6 - Show an alert dialog when no appropriate file manager was found #7452
19 - Do not repeatedly say "Video preview thumbnail" when in reader mode #7619
37 - Increase playlist stuck target duration coefficient and catch
BehindLiveWindowExceptions
properly #7661Fixed
4 - Fix order of local search results #7491
8 - Respect cutouts when playing in MultiWindow #7451
10 - Fixes hashtags that use non-English characters. #7556
11 - Fix readme link #6855
15 - Fixes view of sub-channel icon when not in use #7582
17 - Fixed search not accepting key input after closing player overlay #7607
18 - Load full stream info before using a stream, fixing empty fields in play queue #7036
22 - Fix crash when sharing a playlist which is loading #7662
23 - Workaround: Set recovery before switching player #7668
28 - Add app icon to fastlane metadata #7672
29 - Always show playing in background/popup toast #7614, reverting #7224 and #7568
32 - Fix first item always played in the play queue when reloading play queue manager #7693
33 - Load uploader url when showing channel details from play queue #7538
41 - Fix crash when long-pressing stream while player is starting #7704
Development
1 - Update/Fix "Get it on F-Droid" #7498⚠️ The app requires now Java 11 to be built
3 - Bump ktlint, Checkstyle, Java version #7500
7 - Update a bunch of libraries #7499
9 - Readd sonar CI job #7552
12 - Small improvements to code quality and readability #7562
14 - Update NewPipeExtractor #7589
20 - CI: Upload test-report when an error occurs #7636
21 - Replace JUnit asserts with AssertJ in HistoryRecordManagerTest #7654
24 - Fix false warning #7648
25 - Add traditional Chinese README #7618
26 - Some untranslatable string improvements #7317
27 - Ensure order of search history entries in tests #7670
30 - Sync weblate #7689
31 - Fix some gradle deprecations #7678
34 - Improve HistoryRecordManager tests #7700
38 - Move translated READMEs to subfolder #7784
39 - Update FUNDING.yml #7682
40 - Small changes to license section of README #7710
42 - Add some stuff to paths-ignore #7803
Extractor
Fixed
2- Disabled
SoundcloudStreamExtractorTest#SoundcloudGeoRestrictedTrack#testRelatedItems
as it's unreliable TeamNewPipe/NewPipeExtractor#7614 - [YouTube] parse timestamps with >3 digits correctly TeamNewPipe/NewPipeExtractor#775
Development
1 - Bump spotbugs-annotations from 4.5.0 to 4.5.3 TeamNewPipe/NewPipeExtractor#759 TeamNewPipe/NewPipeExtractor#764 TeamNewPipe/NewPipeExtractor#772
3 - Cleanup: Remove old ways of getting YT dis/likes and more TeamNewPipe/NewPipeExtractor#755
5 - Convert tests to JUnit 5 TeamNewPipe/NewPipeExtractor#768