Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Remove old ways of getting YT dis/likes #755

Merged
merged 6 commits into from
Dec 27, 2021

Conversation

litetex
Copy link
Member

@litetex litetex commented Nov 30, 2021

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Some clean/followups after #753; Content

  • Removed old way of getting likes (was disabled by YT - as predicted - on 2021-12-13)
  • Removed dislike calculation because it no longer works (no average rating)
  • Fixes Exception from Could not parse "No Likes" in 0.21.14 NewPipe#7525
  • Deduplicated a ton of code inside the StreamExtractor(s) by using default/non-abstract methods
  • Fixed tests

@litetex litetex added the youtube service, https://www.youtube.com/ label Nov 30, 2021
@opusforlife2
Copy link
Collaborator

I suppose it will have to be a hotfix.

@litetex
Copy link
Member Author

litetex commented Dec 1, 2021

I don't think we have to hotfix this as everything should still work as expected.
However this PR removes the code that by then will be (likely) irrelevant.
So this is just an improvement :)

@opusforlife2
Copy link
Collaborator

Oh, I was confused. The calculation method will still work.

@litetex litetex force-pushed the clean-up-yt-dis-likes branch from 7904151 to a6961c5 Compare December 27, 2021 15:54
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@litetex litetex marked this pull request as ready for review December 27, 2021 17:25
@litetex litetex merged commit 10f6cc7 into TeamNewPipe:dev Dec 27, 2021
@litetex litetex deleted the clean-up-yt-dis-likes branch December 27, 2021 17:32
@litetex litetex restored the clean-up-yt-dis-likes branch December 27, 2021 18:15
@litetex litetex deleted the clean-up-yt-dis-likes branch December 27, 2021 18:16
@AudricV AudricV added bug Issue is related to a bug enhancement New feature or request multiservice Issues related to multiple services labels Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug enhancement New feature or request multiservice Issues related to multiple services youtube service, https://www.youtube.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants