Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false warning #7648

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Fix false warning #7648

merged 1 commit into from
Jan 19, 2022

Conversation

triallax
Copy link
Contributor

@triallax triallax commented Jan 12, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Fix false warning.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@triallax triallax added the codequality Improvements to the codebase to improve the code quality label Jan 12, 2022
@litetex
Copy link
Member

litetex commented Jan 16, 2022

@mhmdanas

Remove unneeded safe call operator

Why is it unneeded / Why did you remove it in the first place?

@triallax
Copy link
Contributor Author

triallax commented Jan 17, 2022

When I compiled the app, I always got a warning that ?. was unnecessary here, so I removed it.

Edit: nevermind, that's an incorrect warning:

private fun tryGetNewItemsLoadedButton(): Button? {

I'll modify the code to use this method. Thank you for making me notice this issue.

@triallax triallax marked this pull request as draft January 17, 2022 04:13
@triallax triallax changed the title Remove unneeded safe call operator Fix false warning Jan 18, 2022
@triallax triallax marked this pull request as ready for review January 18, 2022 04:55
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@litetex litetex merged commit f681b0b into TeamNewPipe:dev Jan 19, 2022
@Stypox Stypox mentioned this pull request Jan 27, 2022
10 tasks
This was referenced Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants