Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some stuff to paths-ignore #7803

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Add some stuff to paths-ignore #7803

merged 2 commits into from
Feb 9, 2022

Conversation

triallax
Copy link
Contributor

@triallax triallax commented Feb 4, 2022 •
edited
Loading

What is it?

  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Add .github/FUNDING.yml and everything in doc to paths-ignore.

APK testing

Not needed.

Due diligence

@triallax triallax added meta Related to the project but not strictly to code CI Everything related to CI (Continuous integration) labels Feb 4, 2022
@triallax triallax changed the title Add files in doc to paths-ignore Add some stuff to paths-ignore Feb 4, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

litetex
litetex approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Btw, I think we could also ignore all markdown files...

@triallax
Copy link
Contributor Author

triallax commented Feb 7, 2022

Btw, I think we could also ignore all markdown files...

Sure, should I push a commit here?

@litetex
Copy link
Member

litetex commented Feb 8, 2022

Sure, should I push a commit here?

Feel free to do so.
If you open another branch I'm also fine 😄

@triallax
Copy link
Contributor Author

triallax commented Feb 8, 2022 •
edited
Loading

If you open another branch I'm also fine 😄

I'll do that then. Can I merge this? Guess we should wait till 0.22.0 is out...

@litetex
Copy link
Member

litetex commented Feb 9, 2022

Guess we should wait till 0.22.0 is out...

Why should we?
The dev-branch is not blocked and I see no problems that could affect the release.
So merging it is.

@litetex litetex merged commit 1278fc2 into TeamNewPipe:dev Feb 9, 2022
@triallax
Copy link
Contributor Author

@litetex indeed, but it creates more work for a certain blog post author, which is why I thought we may want to avoid it.

This was referenced Feb 11, 2022
Closed
Merged
@Poolitzer
Copy link
Member

they said one. Now I wonder who from us mhmdanas meant...

@opusforlife2
Copy link
Collaborator

Schrodinger's blogger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litetex litetex litetex approved these changes

Assignees
No one assigned
Labels
CI Everything related to CI (Continuous integration) meta Related to the project but not strictly to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@triallax @litetex @Poolitzer @opusforlife2