-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FSFE-Tube PeerTube instance #7481
Conversation
sharing the direct link to download apk here 'cz the "app" button is somehow not clickable on my phone (even despite "desktop site" being enabled): link hidded for foll reason edit: ohwww, it requires logging in. ohkayy. |
hey, so,
Crash report on 2nd try:Open media.fsfe.org link and choose video player Exception
Crash log
|
Hmm, not sure. Regarding the crash, looks like #6860 to me. |
Nice that u could find the crash's dedicated issue and documented it. but just saying, i am like illiterate for crash logs. so, i dont know about it at all 😅 also, any idea for the case when it just goes blank?? update: yeah, seems the u are right and also, that issue itself is heading in right direction. as i tried accessing peertube's video from within newpipe (by changing in the sidebar) and yes, opening any video crashed it, and playing it in bg eventually showed the toast that "couldnt play this stream" |
Note that playing PeerTube videos in the background is not currently supported: #3671 Also, this issue probably affects only some PeerTube videos. |
LGTM I think in the long term we can't add every Peertube instance inside that list. We need a new solution like #7456 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
What is it?
Description of the changes in your PR
Add FSFE-Tube PeerTube instance.
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence
@yashpalgoyal1304 does this fix the issue for you?