Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FSFE-Tube PeerTube instance #7481

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

triallax
Copy link
Contributor

@triallax triallax commented Dec 1, 2021

What is it?

  • Feature (user facing)

Description of the changes in your PR

Add FSFE-Tube PeerTube instance.

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@yashpalgoyal1304 does this fix the issue for you?

@triallax triallax added feature request Issue is related to a feature in the app peertube Service, https://joinpeertube.org/ labels Dec 1, 2021
@goyalyashpal
Copy link
Contributor

goyalyashpal commented Dec 2, 2021

sharing the direct link to download apk here 'cz the "app" button is somehow not clickable on my phone (even despite "desktop site" being enabled): link hidded for foll reason

edit: ohwww, it requires logging in. ohkayy.

@goyalyashpal
Copy link
Contributor

goyalyashpal commented Dec 2, 2021

hey, so,

  • as far as the changes are concerned, sure they work. on clicking the media.fsfe.org/... link from some app (telegram in my case), sure ths newpipe debug app is shown in the open with dialog.
  • butttt i am not sure that the following behaviour is okay. so i am kinda documenting all of it with my comments
  1. shown in the newpipe popup dialog is "video player, popup player, download, add to playlist" but not show video details. is that expected?
  2. on choosing (tapping) video player:
    • loading, then went blank, and exited w/o error, nothing played: 1st, 3rd,
    • crashed: 2nd, 4th, 5th, 6th try

Crash report on 2nd try:

Open media.fsfe.org link and choose video player

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: US
  • Content Language: en-US
  • App Language: en_US
  • Service: none
  • Version: 0.21.13
  • OS: Linux Android 11 - 30
Crash log

java.lang.NumberFormatException: For input string: ""
 at java.lang.Integer.parseInt(Integer.java:627)
 at java.lang.Integer.parseInt(Integer.java:650)
 at org.schabi.newpipe.util.ListHelper.compareVideoStreamResolution(ListHelper.java:488)
 at org.schabi.newpipe.util.ListHelper.compareVideoStreamResolution(ListHelper.java:503)
 at org.schabi.newpipe.util.ListHelper.$r8$lambda$UGNhfSv5KuYwsqrcThyeG189sI0(Unknown Source:0)
 at org.schabi.newpipe.util.ListHelper$$ExternalSyntheticLambda0.compare(Unknown Source:4)
 at java.util.Collections$ReverseComparator2.compare(Collections.java:5235)
 at java.util.TimSort.countRunAndMakeAscending(TimSort.java:360)
 at java.util.TimSort.sort(TimSort.java:220)
 at java.util.Arrays.sort(Arrays.java:1492)
 at java.util.ArrayList.sort(ArrayList.java:1470)
 at java.util.Collections.sort(Collections.java:206)
 at org.schabi.newpipe.util.ListHelper.sortStreamList(ListHelper.java:269)
 at org.schabi.newpipe.util.ListHelper.getSortedStreamVideosList(ListHelper.java:243)
 at org.schabi.newpipe.util.ListHelper.getSortedStreamVideosList(ListHelper.java:130)
 at org.schabi.newpipe.fragments.detail.VideoDetailFragment.handleResult(VideoDetailFragment.java:1602)
 at org.schabi.newpipe.fragments.detail.VideoDetailFragment.lambda$runWorker$6$org-schabi-newpipe-fragments-detail-VideoDetailFragment(VideoDetailFragment.java:913)
 at org.schabi.newpipe.fragments.detail.VideoDetailFragment$$ExternalSyntheticLambda2.accept(Unknown Source:8)
 at io.reactivex.rxjava3.internal.observers.ConsumerSingleObserver.onSuccess(ConsumerSingleObserver.java:62)
 at io.reactivex.rxjava3.internal.operators.single.SingleObserveOn$ObserveOnSingleObserver.run(SingleObserveOn.java:81)
 at io.reactivex.rxjava3.android.schedulers.HandlerScheduler$ScheduledRunnable.run(HandlerScheduler.java:123)
 at android.os.Handler.handleCallback(Handler.java:938)
 at android.os.Handler.dispatchMessage(Handler.java:99)
 at android.os.Looper.loop(Looper.java:261)
 at android.app.ActivityThread.main(ActivityThread.java:8259)
 at java.lang.reflect.Method.invoke(Native Method)
 at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:632)
 at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1049)

@triallax
Copy link
Contributor Author

triallax commented Dec 2, 2021

shown in the newpipe popup dialog is "video player, popup player, download, add to playlist" but not show video details. is that expected?

Hmm, not sure.

Regarding the crash, looks like #6860 to me.

@goyalyashpal
Copy link
Contributor

goyalyashpal commented Dec 2, 2021

Nice that u could find the crash's dedicated issue and documented it. but just saying, i am like illiterate for crash logs. so, i dont know about it at all 😅

also, any idea for the case when it just goes blank??


update: yeah, seems the u are right and also, that issue itself is heading in right direction. as i tried accessing peertube's video from within newpipe (by changing in the sidebar) and yes, opening any video crashed it, and playing it in bg eventually showed the toast that "couldnt play this stream"

@triallax
Copy link
Contributor Author

triallax commented Dec 2, 2021

and playing it in bg eventually showed the toast that "couldnt play this stream"

Note that playing PeerTube videos in the background is not currently supported: #3671

Also, this issue probably affects only some PeerTube videos.

@litetex
Copy link
Member

litetex commented Dec 2, 2021

LGTM
However I'm not sure if we should add this instance in the first place:
https://media.fsfe.org/about/instance
There are only ~120 videos (uploaded by one user) with under 2k views within the last 5 years on that instance.
The other instances in that list usually have > 100k views and

I think in the long term we can't add every Peertube instance inside that list. We need a new solution like #7456

Copy link

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@triallax
Copy link
Contributor Author

triallax commented Dec 2, 2021

@litetex this PR merely adds link support for FSFE-Tube, so I don't see why we should hold back.

I think in the long term we can't add every Peertube instance inside that list. We need a new solution like #7456

Maybe, but until then, we're stuck with this. :)

@litetex litetex merged commit ad405d9 into TeamNewPipe:dev Dec 7, 2021
@goyalyashpal

This comment has been minimized.

This was referenced Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app peertube Service, https://joinpeertube.org/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fsfe tube
5 participants