Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YouTube] parse timestamps with >3 digits correctly #775

Merged
merged 2 commits into from
Jan 12, 2022
Merged

[YouTube] parse timestamps with >3 digits correctly #775

merged 2 commits into from
Jan 12, 2022

Conversation

triallax
Copy link
Contributor

Fixes TeamNewPipe/NewPipe#7530; check the issue for details.

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • (API was not changed) I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

NewPipe.zip

@triallax triallax added bug Issue is related to a bug youtube service, https://www.youtube.com/ labels Jan 10, 2022
@triallax triallax mentioned this pull request Jan 10, 2022
Closed
4 tasks
@XiangRongLin
Copy link
Collaborator

Failure is from Soundcloud

@XiangRongLin XiangRongLin merged commit 65df39b into TeamNewPipe:dev Jan 12, 2022
@triallax triallax deleted the fix-youtube-timestamp-parser-ignoring-thousands-and-above branch January 12, 2022 10:20
This was referenced Feb 11, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiangRongLin XiangRongLin XiangRongLin approved these changes

Assignees
No one assigned
Labels
bug Issue is related to a bug youtube service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Video open at the wrong timestamp (thousands place digit ignored)
2 participants
@triallax @XiangRongLin