Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ktlint, Checkstyle, Java version #7500

Merged
merged 4 commits into from
Dec 12, 2021
Merged

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Move plugins to the DSL block because it's cool
  • Compile with Java 11 (we can because we compile on SDK 30)
  • Update Sonarqube 3.1.1 -> 3.3 (changelog)
  • Update ktlint 0.40.0 -> 0.43.2 (and run it) (changelog)
  • Update Checkstyle 8.38 -> 9.2 (and run it) (changelog)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM some minor things

@litetex litetex merged commit b056faa into TeamNewPipe:dev Dec 12, 2021
@TacoTheDank TacoTheDank deleted the bumpKtlint branch December 13, 2021 00:24
This was referenced Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants