Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "list_thumbnail_view_description" #7619

Merged

Conversation

litetex
Copy link
Member

@litetex litetex commented Jan 4, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Fixes #7583 by simply (KISS) removing the accessibility description "list_thumbnail_view_description".

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

due to accessibility problems
@litetex litetex added the accessibility Issue is related to accessibility label Jan 4, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and to the issue opener

@Stypox Stypox merged commit 1475ff8 into TeamNewPipe:dev Jan 7, 2022
@litetex litetex deleted the removed-list_thumbnail_view_description branch January 8, 2022 19:35
This was referenced Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issue is related to accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility: "Video preview thumbnail"
2 participants