Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invidious support #352

Closed
wants to merge 19 commits into from
Closed

Invidious support #352

wants to merge 19 commits into from

Conversation

B0pol
Copy link
Member

@B0pol B0pol commented Jun 11, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

TODO

  • implement InvidiousChannelExtractor
  • implement InvidiousChannelInfoItemExtractor
  • implement InvidiousCommentsExtractor
  • implement InvidiousCommentsInfoItemExtractor
  • implement InvidiousFeedExtractor
  • implement InvidiousStreamInfoItemExtractor
  • implement InvidiousPlaylistExtractor
  • implement InvidiousPlaylistInfoItemExtractor
  • implement InvidiousSearchExtractor
  • implement InvidiousSuggestionExtractor
  • implement InvidiousTrendingExtractor
  • add tests in NewPipeTest.java for Invidious (it will partially fix NewPipeTest.java only test YouTube #347)
  • handle when instance is semi-blocked: i.e. when video is available but metadata are missing, e.g.
    image
  • add tests
  • test in NewPipe
  • next page logic when there is no continuation field but a page url parameter.
  • mix extractor?

what can't be done:

  • MusicSearchExtractor

maybe:

  • search filters? the api provides
sort_by: "relevance", "rating", "upload_date", "view_count"
date: "hour", "today", "week", "month", "year"
duration: "short", "long"
type: "video", "playlist", "channel", "all", (default: video)
features: "hd", "subtitles", "creative_commons", "3d", "live", "purchased", "4k", "360", "location", "hdr" (comma separated: e.g. "&features=hd,subtitles,3d,live")
region: ISO 3166 country code (default: "US")

currently we only sort by "type". IMO it shouldn't be in this PR, but in a separate one fixing #106 (and that will do for YouTube, Invidious, maybe PeerTube because the issue isn't about PeerTube but it's related).

You can push to the invidious branch if you want, but please announce you are working on invidiousXextractor before so that we are not two people wasting time on the same extractor.

  • implement metaInfo, streamSegments?

@B0pol B0pol marked this pull request as draft June 11, 2020 19:35
@wb9688 wb9688 added this to the 0.20.0 milestone Jun 13, 2020
@obeho
Copy link

obeho commented Oct 18, 2020

Is this PR still under active development?

Btw, thanks for v0.20.1.

@B0pol B0pol closed this Feb 20, 2021
@B0pol B0pol mentioned this pull request Feb 20, 2021
3 tasks
@B0pol B0pol deleted the invidious branch February 20, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invidious
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept all invidious instances
4 participants