-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invidious support #555
Invidious support #555
Conversation
9e43a06
to
1bc8703
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
...src/main/java/org/schabi/newpipe/extractor/services/youtube/invidious/InvidiousInstance.java
Show resolved
Hide resolved
*/ | ||
void fetchInstanceMetaData() throws InvalidInstanceException; | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the missing newline.
@@ -8,6 +8,7 @@ | |||
import org.schabi.newpipe.extractor.NewPipe; | |||
import org.schabi.newpipe.extractor.StreamingService; | |||
import org.schabi.newpipe.extractor.exceptions.ContentNotAvailableException; | |||
import org.schabi.newpipe.extractor.exceptions.ExtractionException; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you can see it's a draft PR meaning it's not finished
* allows usage of YouTubeLike services, e.g. invidious * simplified some classes/code * Added support for invidious * Some credits go to @B0pol's PR TeamNewPipe#555 for that ;)
* allows usage of YouTubeLike services, e.g. invidious * simplified some classes/code * Added support for invidious * Some credits go to @B0pol's PR TeamNewPipe#555 for that ;)
* allows usage of YouTubeLike services, e.g. invidious * simplified some classes/code * Added support for invidious * Some credits go to @B0pol's PR TeamNewPipe#555 for that ;)
* allows usage of YouTubeLike services, e.g. invidious * simplified some classes/code * Added support for invidious * Some credits go to @B0pol's PR TeamNewPipe#555 for that ;)
#352 with minor changes and rebased.