Fix hyper

[polachok]

Upgrades hyper to latest master

[mention-bot]

Thanks @polachok for contributing to The Framework Benchmarks! @steveklabnik, code you've worked on has been modified. If you have the chance, please review. If you wish to unsubscribe from these notices, please add your name to the userBlacklist array in the .mention-bot file.

[steveklabnik]

one extremely tiny nit, but LGTM

[steveklabnik]

standard rust style is to_string not to_owned (but they do the exact same thing)

[polachok]

fixed

[alexcrichton]

Oh one strategy this may wish to take as well is to check in Cargo.lock and avoid the need for rev = "..." in the dependency specification, but that's completely optional!

[steveklabnik]

@alexcrichton I don't remember why I didn't do it that way, but I think there was some kind of issue. Can't remember; that was like two years ago or something. I could have messed it up too.

[alexcrichton]

Ah yeah tokio-minihttp nowdays has Cargo.lock, so I figured it'd be ok to throw in here as well (but again, just an optional extension)

[arthurprs]

It's a bit naive to allocate a string on every reques just to set the server header. I'm sure it doesn't matter in practice but it may show in a hello-world benchmark

[polachok]

@arthurprs well, that's how Server is defined https://hyper.rs/hyper/0.8.0/hyper/header/struct.Server.html

[arthurprs]

I see, Server is also required by the test rules.

[NateBrady23]

Looks like there's agreement to close this in favor of #2619

Closing this and merging that. Thanks guys!