Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: hyper on tokio-proto/service #2619

Merged
merged 1 commit into from
Mar 30, 2017
Merged

Conversation

nayato
Copy link
Contributor

@nayato nayato commented Mar 25, 2017

Refresh for hyper benchmark based on tokio-proto and tokio-service.
serde-derive is used for json serialization as that's what people
will do in real app.

@mention-bot
Copy link

Thanks @nayato for contributing to The Framework Benchmarks! @steveklabnik, @polachok and @nbrady-techempower, code you've worked on has been modified. If you have the chance, please review. If you wish to unsubscribe from these notices, please open a Pull Request with the commit message [ci skip] and your name added to the userBlacklist array in the .mention-bot file.

@nayato
Copy link
Contributor Author

nayato commented Mar 25, 2017

@nayato nayato force-pushed the hyperup branch 2 times, most recently from 2ce7ade to 5ba6a30 Compare March 25, 2017 05:08
@nayato
Copy link
Contributor Author

nayato commented Mar 25, 2017

@polachok just noticed a couple hours back that there's #2611. I aligned my changes to your PR now and will rebase once yours is in.

Refresh for hyper benchmark based on tokio-proto and tokio-service.
serde-derive is used for json serialization as that's what people
will do in real app.
@alexcrichton
Copy link
Contributor

Ah yeah I was otherwise just going to recommend #2611, but other than that looks great!

@NateBrady23 NateBrady23 mentioned this pull request Mar 30, 2017
@NateBrady23 NateBrady23 merged commit 09a729d into TechEmpower:master Mar 30, 2017
@nayato nayato deleted the hyperup branch March 30, 2017 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants