Skip to content

Add and hook up Admin URL theme property #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Develop/bespoke
merged 1 commit into from
Sep 24, 2025
Merged

Add and hook up Admin URL theme property #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions classes/output/core_renderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,10 +182,19 @@ public function get_global_header_data() {
$processed_item->title = $item['title'] ?? 'Untitled'; // Default title if missing
// Handle URLs - convert to moodle_url if internal, keep as string if external
if (isset($item['url']) && !empty($item['url'])) {
$item_url_path = $item['url']; // Store the raw URL from the API

$item_url_path = $item['url']; // Store the raw URL from the API
// --- NEW: Override URL for 'Admin' link with theme setting ---
if (trim($processed_item->title) === 'Admin') {
$admin_url = get_config('theme_nhse', 'admin_url');
if (!empty($admin_url)) {
$processed_item->url = $admin_url;
error_log("theme_nhse: Overriding 'Admin' URL with theme setting: {$processed_item->url}");
} else {
// Fallback to original logic if theme setting is not configured
error_log("theme_nhse: Admin URL theme setting not found, falling back to API URL.");
}
// Check if it's an absolute URL (starts with http/s or //)
if (strpos($item_url_path, 'http') === 0 || strpos($item_url_path, '//') === 0) {
} else if (strpos($item_url_path, 'http') === 0 || strpos($item_url_path, '//') === 0) {
$processed_item->url = $item_url_path; // Use the absolute URL as is
error_log("theme_nhse: Processing absolute URL: {$processed_item->url}");
}
Expand Down
14 changes: 12 additions & 2 deletions settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
$settings = new theme_boost_admin_settingspage_tabs('themesettingnhse', get_string('configtitle', 'theme_nhse'));
$page = new admin_settingpage('theme_nhse_general', get_string('generalsettings', 'theme_nhse'));

// --- NEW: Add the .NET Application Base URL setting to the 'General' tab ---
// Theme customisable property: Add the .NET Application Base URL setting to the 'General' tab ---
$page->add(new admin_setting_configtext(
'theme_nhse/dotnet_base_url', // Unique identifier for this setting
get_string('dotnet_base_url_setting', 'theme_nhse'), // Display title
Expand All @@ -35,7 +35,7 @@
PARAM_URL // Moodle will validate the input as a URL
));

// --- NEW: Add the API Base URL setting ---
// Theme customisable property: Add the API Base URL setting ---
$page->add(new admin_setting_configtext(
'theme_nhse/api_base_url', // Unique identifier for this setting
get_string('api_base_url_setting', 'theme_nhse'), // Display title
Expand All @@ -44,6 +44,16 @@
PARAM_URL // Moodle will validate this as a URL
));

// Theme customisable property: Add the Admin URL setting ---
$page->add(new admin_setting_configtext(
'theme_nhse/admin_url', // Unique identifier for this setting
get_string('admin_url_setting', 'theme_nhse'), // Display title
get_string('admin_url_setting_desc', 'theme_nhse'), // Description
'', // Default value (empty string)
PARAM_URL // Moodle will validate this as a URL
));


// Unaddable blocks.
// Blocks to be excluded when this theme is enabled in the "Add a block" list: Administration, Navigation, Courses and
// Section links.
Expand Down