Process overScrollBy events while view is not being dragged #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpastor
requested review from
a team,
gmerinojimenez and
pmartinbTEF
and removed request for
a team
Comment on lines
+667
to
+677
| public void dispatchOverScrollIfNotBeingDragged( | ||
| int deltaX, | ||
| int deltaY, | ||
| int scrollX, | ||
| int scrollY, | ||
| int scrollRangeX, | ||
| int scrollRangeY, | ||
| int maxOverScrollX, | ||
| int maxOverScrollY, | ||
| boolean isTouchEvent | ||
| ) { |
There was a problem hiding this comment.
looks like an Objective C Zigurat :D
|
Discarding this PR, as this will be integrated in this another one --> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Internal Jira ticket
ANDROID-11710
🥅 What's the goal?
Fix an issue that was making webview scroll to be maintained when user navigates to a new page.
🚧 How do we do it?
🧪 How can I check this?
Record_2023-05-11-10-14-24.mp4