Skip to content

Process overScrollBy events while view is not being dragged #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dpastor
Copy link
Contributor

@dpastor dpastor commented May 11, 2023

🎟️ Internal Jira ticket

ANDROID-11710

πŸ₯… What's the goal?

Fix an issue that was making webview scroll to be maintained when user navigates to a new page.

🚧 How do we do it?

  • Just process overScrollBy events in cases view is not being dragged, as we should not do it otherwise to avoid double overscrolling.

πŸ§ͺ How can I check this?

  • πŸ–ΌοΈ Screenshots/Videos
Record_2023-05-11-10-14-24.mp4

@dpastor dpastor requested review from a team, gmerinojimenez and pmartinbTEF and removed request for a team May 11, 2023 08:25
Comment on lines +667 to +677
public void dispatchOverScrollIfNotBeingDragged(
int deltaX,
int deltaY,
int scrollX,
int scrollY,
int scrollRangeX,
int scrollRangeY,
int maxOverScrollX,
int maxOverScrollY,
boolean isTouchEvent
) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like an Objective C Zigurat :D

Copy link

@gmerinojimenez gmerinojimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Copy link
Contributor

@pmartinbTEF pmartinbTEF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpastor
Copy link
Contributor Author

dpastor commented May 25, 2023

Discarding this PR, as this will be integrated in this another one -->

#8

@dpastor dpastor closed this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants