Refactor, Fixes, and functionality to avoid processing nested scroll events on internal webview elements scrolls #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and improvements
…nd horizontal scrolls, also, update readme
dpastor
changed the title
1 task
dagonco
reviewed
May 25, 2023
| val y = event.getY(activePointerIndex) | ||
| val x = event.getX(activePointerIndex) | ||
| val deltaY: Float = initialY!! - y | ||
| val deltaX: Float = initialX!! - x |
There was a problem hiding this comment.
Could we have a concurrency issue here?
I mean, initialX for example could be nullable. To avoid a possible problem could we store in this method these two coordinates and use them instead using initialX/Y? Just to be sure these two values couldnt be null any time in this instance
There was a problem hiding this comment.
It shouldn't because all class methods should be always executed from main thread (All are related with touch events processing or scrolls performed that will be sequentially invoked).
In any case it would be clear and we won't need the !!. I'm applying it --> d629d4c
gmerinojimenez
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira tickets
ANDROID-13326
ANDROID-11710
🥅 What's the goal?
I decided to revert the "helper" approach to extract to an specific file code extracted from NestedScrollView support library code, this was leading to issues due methods not calling directly WebView methods (Specially all the ones related with NestedScrollingChild3 interface implementation). So I just added this directly to the NestedScrollWebView class, identifying support library code with an specific comment block (trying to keep it as unaltered as possible for future updates).
Fixed also an issue where scroll was maintained after navigating to a new page (ANDROID-11710) -->
Record_2023-05-11-10-14-24.mp4
Record_2023-05-24-19-03-54.mp4
Record_2023-05-24-19-02-56.mp4